Re: [PATCH v2 2/2] dt-bindings: i2c: rtl9300: add 'rtl9607c-i2c'

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: i2c: missing patternProperties restriction for rtl9607c-i2c
--

commit 9c59eaea467911b21ec4b5c1d3ef7e034bb19883
Author: Michael Zavertkin <misha.zavertkin@mail.ru>

dt-bindings: i2c: rtl9300: add 'rtl9607c-i2c'

Add realtek,rtl9607c-i2c compatible for RTL9607C SoC, deprecate the old one,
and rely on pinctrl driver for pin assignment.

> diff --git a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
> index 5873cfdc5b3e0..7c00918f33c8d 100644
> --- a/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/realtek,rtl9301-i2c.yaml

[ ... ]

> @@ -96,6 +104,16 @@ allOf:
>        required:
>          - realtek,scl
>          - clocks
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: realtek,rtl9607c-i2c
> +    then:
> +      required:
> +        - clocks
> +        - pinctrl-0
> +        - pinctrl-names

[Severity: Low]
Does this conditional block need to restrict the allowed child nodes?

The RTL9607C hardware only supports 1 channel, but the base schema permits
any child node matching '^i2c@[0-9ab]$'.

Without adding a restriction such as patternProperties: '^i2c@[1-9ab]$': false
to this block, dt_binding_check could incorrectly pass single child nodes
with invalid reg indices, like i2c@1 or i2c@b.

Since the driver ignores the SDA index during configuration, it would accept
these invalid reg values without error.

Could we restrict the pattern here to prevent invalid channel definitions?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791611999.git.misha.zavertkin@mail.ru?part=2