Re: [PATCH v5 02/10] dt-bindings: iio: adc: support the TI ADS126x ADC family

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing mandatory required properties for GPIO controller
--

commit 71f9ec7fa4f648264b425d77eb77849a06771e4a
Author: Kurt Borja <kuurtb@gmail.com>

dt-bindings: iio: adc: support the TI ADS126x ADC family

The ADS1262 and ADS1263 are 32-bit, 38.4-kSPS delta-sigma ADCs with an
integrated PGA, internal reference, excitation and burn-out current
sources for sensor biasing and diagnostics. The ADS1263 is compatible
with ADS1262, but includes a second auxiliary ADC (ADC2).

> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1262.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1262.yaml
> new file mode 100644
> index 0000000000000..d9957aa509d8c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1262.yaml
[ ... ]
> +  '#gpio-cells':
> +    const: 2
> +
> +  gpio-controller: true
> +
> +  regulators:
> +    type: object
[ ... ]
> +dependencies:
> +  interrupts: [interrupt-names]
> +  interrupts-extended: [interrupt-names]
> +
> +required:
> +  - compatible
> +  - reg
> +  - spi-cpha
> +  - avdd-supply
> +  - dvdd-supply
> +  - '#address-cells'
> +  - '#size-cells'

[Severity: Medium]
Since this hardware adds provider capabilities by defining gpio-controller and
#gpio-cells, shouldn't these properties be explicitly included in the required
list?

When hardware gains new provider capabilities like a GPIO controller, the
dt-bindings subsystem guidelines state that the corresponding properties should
be mandatory. Omitting them from the required list allows incomplete device
tree nodes to silently pass schema validation, which could cause drivers or
dependent subsystems to fail at runtime.

> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010-ads126x-v5-0-49e331cb2fed@gmail.com?part=2