Re: [PATCH 7/7] arm64: dts: mediatek: mt8167: Add HDMI display nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: mt8167: hdmiddc compatible array violates schema enum constraint
--

commit c20e20334411b75b4e2b444ca191ccb04b2ad0ef
Author: Luca Leonardo Scorcia <l.scorcia@gmail.com>

arm64: dts: mediatek: mt8167: Add HDMI display nodes

This commit adds the required device tree nodes to enable HDMI output on the
mt8167 SoC.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8167.dtsi b/arch/arm64/boot/dts/mediatek/mt8167.dtsi
> index 27cf32d7ae35f..ab76e0637eb15 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8167.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8167.dtsi

[ ... ]

> @@ -120,6 +141,15 @@ iommu: m4u@10203000 {
>  			#iommu-cells = <1>;
>  		};
>  
> +		hdmiddc: i2c@11011000 {
> +			compatible = "mediatek,mt8167-hdmi-ddc", "mediatek,mt8173-hdmi-ddc";

[Severity: Low]
Does this compatible array violate the devicetree schema constraints?

The mediatek,hdmi-ddc.yaml schema uses an enum constraint for the compatible
property:

properties:
  compatible:
    enum:
      - mediatek,mt7623-hdmi-ddc
      - mediatek,mt8167-hdmi-ddc
      - mediatek,mt8173-hdmi-ddc

This restricts the property to a single string and prevents fallback arrays.

Compiling the devicetree with make dtbs_check will throw a schema validation
warning here.

> +			reg = <0 0x11011000 0 0x10>;
> +			interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_LOW>;
> +			clocks = <&topckgen CLK_TOP_26M_HDMI_SIFM>;
> +			clock-names = "ddc-i2c";
> +			status = "disabled";
> +		};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010115539.9237-1-l.scorcia@gmail.com?part=7