Re: [PATCH v2 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: missing required touchscreen geometry properties
- [Low] dt-bindings: MAINTAINERS entry is not sorted alphabetically
--

commit 6f38b36d3e9ba3bf27f192d07af31696c6e0fdc1
Author: Yibo Wang <wyibo6109@gmail.com>

dt-bindings: input: add OnePlus pogo-pin keyboard

This commit introduces a device tree binding for the Tinno keyboard MCU
used by OnePlus and OPPO smart keyboards. It specifies the properties
for power, transmit gating, and wake GPIOs, along with common touchscreen
attributes.

> diff --git a/Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml b/Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml
> index 0000000000000..9055ececc04cb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml

[ ... ]

> +required:
> +  - compatible
> +  - power-gpios
> +  - tx-enable-gpios
> +  - wake-gpios

[Severity: Medium]
The commit message states that the MCU protocol has no way to query the
touchpad geometry, meaning the driver strictly requires the touchscreen-size-x
and touchscreen-size-y properties to function properly.

Should these properties be added to the required array?

Leaving them out might allow incomplete device tree nodes missing the
dimensions to silently pass schema validation, which could then lead to
runtime failures or misconfigured touchpad coordinates when the driver probes.

> +
> +unevaluatedProperties: false

[ ... ]

> diff --git a/MAINTAINERS b/MAINTAINERS
> index b8c4e1080af94..d81e400059ced 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS

[ ... ]

> @@ -20154,6 +20154,12 @@ S:	Maintained
>  F:	Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-dev
>  F:	drivers/usb/misc/onboard_usb_dev.c
>  
> +ONEPLUS POGO-PIN KEYBOARD DRIVER
> +M:	Yibo Wang <wyibo6109@gmail.com>
> +L:	linux-input@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/input/oneplus,pogo-keyboard.yaml
> +
>  ONENAND FLASH DRIVER

[Severity: Low]
This isn't a bug, but should ONEPLUS POGO-PIN KEYBOARD DRIVER be placed after
ONENAND FLASH DRIVER?

Alphabetically, P comes after N. Breaking alphabetical sorting in the
MAINTAINERS file can cause script warnings with parse-maintainers.pl and
may lead to future merge conflicts.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010143836.173883-1-wyibo6109@gmail.com?part=1