Re: [PATCH v6 3/3] arm64: dts: qcom: sc8280xp-x13s: Add embedded controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: dtbs_check validation failure due to forbidden input-enable property
--

commit a33aecbbb5f75c5311ccdc6af88f07e6aaed6105
Author: Alex Robinson <alex@ironrobin.net>

arm64: dts: qcom: sc8280xp-x13s: Add embedded controller

This commit enables the ThinkPad X13s embedded controller to provide keyboard
backlight support when booting with Device Tree. It also configures the
necessary interrupt lines and pinctrl states.

> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index 218573a97785b..1e29bab37de6d 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts

[ ... ]

> @@ -1571,6 +1590,20 @@ sc-rgb-xshut-n-pins {
>  		};
>  	};
>  
> +	ec_int_n: ec-int-n-state {
> +		pins = "gpio103";
> +		function = "gpio";
> +		input-enable;

[Severity: Low]
Will this property trigger a device tree schema validation regression during
make dtbs_check?

The DT binding schema in Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml,
which is inherited by qcom,sc8280xp-tlmm.yaml, explicitly forbids its use by
setting input-enable: false for qcom-tlmm-state nodes.

> +		bias-pull-up;
> +	};
> +
> +	ec_power_state: ec-power-state {
> +		pins = "gpio176";
> +		function = "gpio";
> +		drive-strength = <2>;
> +		bias-disable;
> +	};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010145519.8370-1-alex@ironrobin.net?part=3