Re: [PATCH 02/10] dt-bindings: interrupt-controller: apple,aic2: Add t6041 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dt-bindings: missing apple,t6041-aic3 in conditional block and t6050-aic3 typo
- [Low] dt-bindings: aic2: apple,t6050-aic3 missing from properties compatible list
--

commit a6480c7857c24d9e74933b42107084ffbaf70be7
Author: Yureka Lilian <yureka@cyberchaos.dev>

dt-bindings: interrupt-controller: apple,aic2: Add t6041 compatible

The Apple t604x (M4 Pro/Max) SoCs use an AIC3 as interrupt controller,
same as the previous M3-M4 SoCs.

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> index e3cadc5ad39d5..fa9d89cb40b1b 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml
> @@ -45,6 +46,7 @@ properties:
>            - enum:
>                - apple,t6030-aic3
>                - apple,t6031-aic3
> +              - apple,t6041-aic3

[Severity: Medium]
This compatible string is correctly introduced here, but it appears to be
missing from the allOf conditional block at the end of the file.

Because apple,t6041-aic3 is missing from the conditional block, schema
validation for valid M4 Max device trees (which specify 4 interrupt cells)
will fall through to the else branch and incorrectly require 3 interrupt
cells.

Will this cause make dt_binding_check and make dtbs_check validation
errors for valid device trees?

>                - apple,t8132-aic3
>                - apple,t8140-aic3
>            - const: apple,t8122-aic3

[ ... ]

> @@ -134,6 +136,7 @@ allOf:
>                - apple,t6000-aic
>                - apple,t6020-aic
>                - apple,t6031-aic3
> +              - apple,t6050-aic3

[Severity: Low]
The string apple,t6050-aic3 is added to this conditional block (which
enforces 4 interrupt cells), but it is omitted from the top-level
properties: compatible list above. 

Is this a typo for apple,t6041-aic3?

Because apple,t6050-aic3 is not declared in the top-level list, its
presence here is dead schema code, and any future device tree using it
will fail schema validation.

>      then:
>        properties:
>          '#interrupt-cells':

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261010-apple-m4-pro-max-initial-devicetrees-v1-0-781fb3f2d9f6@cyberchaos.dev?part=2