Re: [PATCH 1/2] riscv: dts: thead: Enable bluetooth on BeagleV-Ahead

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: missing pinctrl state name for pinctrl-1 in bluetooth node
--

commit d08d8ee5ff25b62d26075da6c5a8d9e0d4d9c5bc
Author: Thomas Gerner <thomas.gerner@muenchen-mail.de>

riscv: dts: thead: Enable bluetooth on BeagleV-Ahead

On the BeagleV-Ahead the bluetooth module of the Ampak AP6203BM is
identified by the btbcm driver as BCM4362A2. The module is connected by
UART4, several gpio pins and an I2S interface.

> diff --git a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> index e16484a476534..bf64eb667745f 100644
> --- a/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-beaglev-ahead.dts

[ ... ]

> @@ -314,3 +380,26 @@ &uart0 {
>  	pinctrl-0 = <&uart0_pins>;
>  	status = "okay";
>  };
> +
> +&uart4 {
> +	pinctrl-0 = <&uart4_pins>;
> +	pinctrl-names = "default";
> +	uart-has-rtscts;
> +
> +	status = "okay";
> +
> +	bluetooth {
> +		compatible = "brcm,bcm4329-bt";
> +		device-wakeup-gpios = <&gpio2 29 GPIO_ACTIVE_HIGH>;
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <30 IRQ_TYPE_EDGE_RISING>;
> +		interrupt-names = "host-wakeup";
> +		max-speed = <921600>;
> +		pinctrl-0 = <&bluetooth_in_pins>;
> +		pinctrl-1 = <&bluetooth_out_pins>;
> +		pinctrl-names = "default";

[Severity: Medium]
Does this leave the pins in pinctrl-1 unconfigured?

Since there is no second name provided in pinctrl-names, the pinctrl subsystem
assigns the auto-generated name "1" to pinctrl-1. The driver core only requests
standard states like "default", which could mean the pin configuration defined
in bluetooth_out_pins (such as drive strength, bias, and slew rate for the
wakeup and shutdown GPIOs) is silently ignored and never applied.

> +		shutdown-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>; 	/* BT-REG-ON */
> +		vbat-supply = <&reg_vbat_3v3>;
> +		vddio-supply = <&reg_vbat_1v8>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1791720467.git.thomas.gerner@muenchen-mail.de?part=1