From: sashiko-bot@kernel.org
To: "Rillian Grant" <rillian.grant@gmail.com>
Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
lee@kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: leds: Document TI LM3643 dual LED flash driver
Date: Sun, 11 Oct 2026 19:14:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-167397@kernel.org> (raw)
In-Reply-To: <20261011191026.149338-2-rillian.grant@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] leds: missing driver name in commit message prefix
--
commit 3be78a7ca4f65d71d150658aa87edd42d6d057a1
Author: Rillian Grant <rillian.grant@gmail.com>
dt-bindings: leds: Document TI LM3643 dual LED flash driver
This commit documents the devicetree bindings for the Texas Instruments
LM3643 dual LED flash driver.
> dt-bindings: leds: Document TI LM3643 dual LED flash driver
[Severity: Low]
This isn't a bug, but does the commit message subject omit the driver name
in the prefix? According to the LED subsystem rules, commit messages should
include the appropriate driver prefix followed by a capitalized description,
such as "dt-bindings: leds: ti,lm3643: Document...". Missing the driver
portion of the prefix hinders Git history categorization and violates
subsystem naming conventions.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261011191026.149338-1-rillian.grant@gmail.com?part=1
next prev parent reply other threads:[~2026-10-11 19:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 19:09 [PATCH v3 0/4] leds: flash: LM3643 dual LED flash driver Rillian Grant
2026-10-11 19:09 ` [PATCH v3 1/4] dt-bindings: leds: Document TI " Rillian Grant
2026-10-11 19:14 ` sashiko-bot [this message]
2026-10-12 9:51 ` Krzysztof Kozlowski
2026-10-11 19:09 ` [PATCH v3 2/4] leds: flash: Add support for the " Rillian Grant
2026-10-11 19:20 ` sashiko-bot
2026-10-11 19:09 ` [PATCH v3 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes Rillian Grant
2026-10-11 19:20 ` sashiko-bot
2026-10-11 19:09 ` [PATCH v3 4/4] leds: flash: lm3643: Describe the LED on the Lenovo ThinkPad X9-15 Gen 1 Rillian Grant
2026-10-11 19:15 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-167397@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rillian.grant@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox