Re: [PATCH v11 6/8] iio: osf: add IIO devices from capability reports

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] iio: osf: dropping valid frames and breaking sysfs cache on full kfifo
--

commit 615eea31301059211a3c98d8229f156971694125
Author: Jinseob Kim <kimjinseob88@gmail.com>

iio: osf: add IIO devices from capability reports

This commit registers IIO devices from supported capability descriptors and
exposes RAW, descriptor-derived SCALE, and initialized active-scan buffers. It
validates complete inventories and sample meaning, and faults incompatible
bound sessions.

> diff --git a/drivers/iio/sensorhubs/osf/osf_core.c b/drivers/iio/sensorhubs/osf/osf_core.c
> index b76619335335f..4f73ff5e9572b 100644
> --- a/drivers/iio/sensorhubs/osf/osf_core.c
> +++ b/drivers/iio/sensorhubs/osf/osf_core.c

[ ... ]

> +	/* Serialize publication and cache admission with the session fault. */
> +	guard(mutex)(&osf->latest_lock);
> +	if (osf->session_fault)
> +		return -EPROTO;
> +
> +	ret = osf_iio_push_sample(indio_dev, values, sample.channel_count);
> +	if (ret) {
> +		dev_err_ratelimited(osf->dev,
> +				    "failed to push sensor %#x:%u sample: %d\n",
> +				    sample.sensor_type, sample.sensor_index, ret);
> +		return ret;
> +	}
> +
> +	latest = osf_core_find_latest_sample(osf, sample.sensor_type,

[Severity: High]
If userspace falls behind reading from the IIO buffer and the kfifo fills up,
osf_iio_push_sample() will return an error (e.g. -EBUSY from the IIO core).

Does returning early here mean we drop the frame completely and skip updating
the latest_samples cache?

Since a full software ring buffer is a normal timing condition and not a
malformed hardware packet, should this code perhaps ignore the buffer push
error and proceed to update the sysfs cache so direct reads continue to work?

> +					     sample.sensor_index);
> +	if (!latest) {

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261011231340.42885-1-kimjinseob88@gmail.com?part=6