Re: [PATCH v3 3/3] Input: add Nsiway NS2009 resistive touchscreen driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] i2c: i2c_device_id array lacks named initializer
--

commit 1329443f9d0fcc43d7767e5dcaca297c790eca05
Author: Mizuno Miotsuki <founder@crepuse.com>

Input: add Nsiway NS2009 resistive touchscreen driver

This commit adds polling support for the Nsiway NS2009 I2C touchscreen
controller. It uses the input polling API, managed input allocation, and
applies coordinate transforms through common touchscreen helpers.

Link: https://lore.kernel.org/all/20170315155140.54518-4-icenowy@aosc.xyz/

> diff --git a/drivers/input/touchscreen/ns2009.c b/drivers/input/touchscreen/ns2009.c
> new file mode 100644
> index 0000000000000..d5c1f9f96bb6b
> --- /dev/null
> +++ b/drivers/input/touchscreen/ns2009.c

[ ... ]

> +static const struct i2c_device_id ns2009_id[] = {
> +	{ "ns2009" },
> +	{ }
> +};

[Severity: Low]
The I2C subsystem guidelines state that initialized arrays of type
struct i2c_device_id must use named initializers. Should the ns2009_id array
use a named initializer, such as { .name = "ns2009" }, instead of a
positional initializer?

> +MODULE_DEVICE_TABLE(i2c, ns2009_id);
> +
> +static const struct of_device_id ns2009_of_match[] = {
> +	{ .compatible = "nsiway,ns2009" },
> +	{ }
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012121705.53396-1-founder@crepuse.com?part=3