Re: [PATCH 1/2] dt-bindings: interrupt-controller: introduce toshiba,tc9564-msigen.yaml

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] dt-bindings: missing mandatory clock and reset properties in required list
- [Low] dt-bindings: non-existent header includes cause dt_binding_check failure
- [Low] dt-bindings: maintainer email addresses mismatch between MAINTAINERS and schema
--

commit 8cfa6ac36f149ea1d1b37b717117b76943010968
Author: Alex Elder <elder@riscstar.com>

dt-bindings: interrupt-controller: introduce toshiba,tc9564-msigen.yaml

Define the binding for the MSIGEN interrupt controller present in the
Toshiba TC9564 SoC.

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/toshiba,tc9564-msigen.yaml b/Documentation/devicetree/bindings/interrupt-controller/toshiba,tc9564-msigen.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/toshiba,tc9564-msigen.yaml
[ ... ]
> +title: Toshiba TC9564 MSIGEN Interrupt Controller
> +
> +maintainers:
> +  - Daniel Thompson <daniel@riscstar.com>
> +  - Alex Elder <elder@riscstar.com>

[Severity: Low]
This isn't a bug, but is this email domain mismatch intentional? The
email addresses listed here in the schema use @riscstar.com, but the
MAINTAINERS file entry added in this same patch uses @kernel.org.

This might cause automated tooling to route patch series to incorrect or
duplicate addresses.

[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - interrupt-controller
> +  - '#interrupt-cells'

[Severity: Medium]
Should clocks and resets be included in this required list? The binding
documentation specifies that each MSIGEN uses a gated clock and reset line.

If they are omitted here, device trees with incomplete hardware configurations
will silently pass schema validation, potentially leading to driver failures
when attempting to ungate clocks or deassert resets on uninitialized hardware.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/toshiba,tc9564.h>
> +    #include <dt-bindings/reset/toshiba,tc9564.h>

[Severity: Low]
Does this cause make dt_binding_check to fail? It looks like these header
files are not included in this patch series.

Including headers in the YAML example that do not exist in the source tree
will usually cause the C preprocessor to fail during schema validation
compilation.

[ ... ]
> diff --git a/MAINTAINERS b/MAINTAINERS
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
[ ... ]
>  F:	drivers/media/i2c/tc358743*
>  F:	include/media/i2c/tc358743.h
>  
> +TOSHIBA TC9564 MSIGEN DRIVER
> +M:	Alex Elder <elder@kernel.org>
> +M:	Daniel Thompson <danielt@kernel.org>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/interrupt-controller/toshiba,tc9564-msigen.yaml
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012190245.3988619-1-elder@riscstar.com?part=1