Re: [PATCH v7 3/3] media: i2c: hm1092: Add ACPI enumeration and the 19.2 MHz configuration

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] media: hm1092: crop rectangle exceeds crop bounds for 19.2 MHz mode
--

commit 49dd5f72932dde1fcdf6ace7b8dcb87f89cb643e
Author: Jake Steinman <j@metarealtyinc.ca>

media: i2c: hm1092: Add ACPI enumeration and the 19.2 MHz configuration

This commit adds support for the HIMX1092 sensor enumerated through ACPI on
Intel IPU6/IPU7 laptops. It converts the single fixed mode into a table of
configurations based on the external clock rate, adding a 19.2 MHz configuration.

Link: https://lore.kernel.org/r/b0d32a3b82eca233652f878b7ca91e4dc2d8e863.1791608336.git.j@metarealtyinc.ca

> diff --git a/drivers/media/i2c/hm1092.c b/drivers/media/i2c/hm1092.c
> index 0ae30fb6b78ff..c7b148076e94c 100644
> --- a/drivers/media/i2c/hm1092.c
> +++ b/drivers/media/i2c/hm1092.c
> @@ -277,18 +275,265 @@ static const struct cci_reg_sequence hm1092_init_regs[] = {

[ ... ]

> +static const struct hm1092_mode hm1092_modes[] = {
> +	{
> +		.mclk = 24000000,
> +		.link_freq_index = 0,
> +		.width = 560,
> +		.height = 360,
> +		.hts = 0x0650,
> +		.vts = 0x02ee,
> +		.exposure_def = 500,
> +		.crop = {
> +			.left = 48,
> +			.top = 8,
> +			.width = 1150,
> +			.height = 718,
> +		},
> +		.regs = hm1092_560x360_regs,
> +		.num_regs = ARRAY_SIZE(hm1092_560x360_regs),
> +	}, {
> +		.mclk = 19200000,
> +		.link_freq_index = 1,
> +		.width = 648,
> +		.height = 368,
> +		.hts = 0x0654,
> +		.vts = 0x02e4,
> +		.exposure_def = 360,
> +		.crop = {
> +			.left = 0,
> +			.top = 0,
> +			.width = 1294,
> +			.height = 734,
> +		},

[Severity: Medium]
Does this crop rectangle exceed the crop bounds reported by
hm1092_get_selection()?

Looking at hm1092_get_selection() when V4L2_SEL_TGT_CROP_BOUNDS is requested,
it returns a smaller region:

	case V4L2_SEL_TGT_CROP_BOUNDS:
		sel->r.left = HM1092_ACTIVE_LEFT; /* 8 */
		sel->r.top = HM1092_ACTIVE_TOP; /* 8 */
		sel->r.width = HM1092_ACTIVE_WIDTH; /* 1280 */
		sel->r.height = HM1092_ACTIVE_HEIGHT; /* 720 */
		return 0;

Since the crop rectangle for the 19.2 MHz mode has a width of 1294 (which
is greater than 1280) and starts at a left offset of 0 (instead of 8), it
extends outside the reported bounds. This violates the V4L2 API contract.
Will this cause v4l2-compliance test failures?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-hm1092-driver-v7-0-d81a9b152ffd@gmail.com?part=3