Re: [PATCH v2] arm64: dts: qcom: shikra-iqs: add M.2 Wi-Fi and Bluetooth overlay

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] dt: unresolved phandles in dtso cause overlay application failure
- [High] dt: missing status okay for i2c3 prevents child devices from probing
--

commit 20bd5cfd16cb2c55b562568723f33d895fa37020
Author: Linghui Wu <linghui.wu@oss.qualcomm.com>

arm64: dts: qcom: shikra-iqs: add M.2 Wi-Fi and Bluetooth overlay
    
Add an overlay for M.2 Key-E Wi-Fi and Bluetooth modules on Qualcomm
Shikra IQS EVK. Describe the PCIe and UART connections through the
M.2 connector, the 3.3 V supply, the W_DISABLE signals and the PCIe
reset signal. Disable the onboard Wi-Fi and Bluetooth nodes when the
overlay is selected.

> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk-m2-wifi-bt.dtso b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-m2-wifi-bt.dtso
> new file mode 100644
> index 0000000000000..9496c6558eef6
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk-m2-wifi-bt.dtso
[ ... ]
> +&i2c3 {
> +	qps_gpio_expander: gpio@3c {
> +		compatible = "nxp,pca9534";
> +		reg = <0x3c>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +	};
> +};

[Severity: High]
Does this overlay need to set status = "okay" for the i2c3 bus?

In the base device tree, the i2c3 bus has status = "disabled". Because the
parent I2C bus remains disabled, the child qps_gpio_expander will never probe.
Consequently, the m2_keye_3p3 regulator, which relies on a GPIO from this
expander, will defer indefinitely, leaving the M.2 Wi-Fi/BT module unpowered.

> +
> +&pcie {
> +	iommu-map = <0x0 &apps_smmu 0x0800 0x0 0x1>,
> +		    <0x100 &apps_smmu 0x0801 0x0 0x1>;
> +	vddpe-3v3-supply = <&m2_keye_3p3>;
> +};

[Severity: High]
Do the &pcie, &pcie_port0, and &tc9563 labels exist in the upstream
platform code?

Applying this overlay at runtime or via the bootloader will fail due to
unresolvable symbols. None of these labels are defined in the upstream
platform code (shikra.dtsi, shikra-iqs-som.dtsi, or shikra-iqs-evk.dts).
Does this overlay rely on unmerged or out-of-tree patches that add PCIe
support to the Shikra platform?

> +
> +&pcie_port0 {
> +	compatible = "pciclass,0604";
> +	reset-gpios = <&tlmm 118 GPIO_ACTIVE_LOW>;
> +
> +	port {
> +		pcie_port0_ep: endpoint {
> +			remote-endpoint = <&m2_e_pcie_ep>;
> +		};
> +	};
> +};
> +
> +&tc9563 {
> +	reg = <0x1ff00 0x0 0x0 0x0 0x0>;
> +	status = "disabled";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013045527.56941-1-linghui.wu@oss.qualcomm.com?part=1