Re: [PATCH v6 1/2] dt-bindings: iio: light: add as7343

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: additionalProperties: false blocks referenced LED properties
--

commit 91a13bd8ef095a37fbdedc3e1a205c8195e990a3
Author: Chang Yu <marcus.yu.56@gmail.com>

dt-bindings: iio: light: add as7343

This commit adds a device tree binding schema for the AMS AS7343, a
14-channel multi-spectral sensor.

> diff --git a/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml
> new file mode 100644
> index 0000000000000..7fb10b0d4843b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/ams,as7343.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - vdd-supply
> +
> +additionalProperties: false
> +
> +allOf:
> +  - $ref: /schemas/leds/common.yaml#

[Severity: Low]
Will additionalProperties: false cause the schema validator to incorrectly
reject valid LED properties? 

Because additionalProperties is set to false at the root level, only the
properties explicitly listed in the local properties dictionary are allowed.
When a device tree author adds standard LED properties (such as function,
color, or label) included by the /schemas/leds/common.yaml reference, they
will fail validation as unallowed additional properties.

Could we use unevaluatedProperties: false instead? This would allow the
properties defined in the externally referenced common LED schema to pass
validation correctly.

> +
> +examples:

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013115639.167433-1-marcus.yu.56@gmail.com?part=1