Re: [PATCH v3 6/7] dt-bindings: beagle: Add BeagleConnect Freedom

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: unconditional SPI ref prevents multi-bus properties
--

commit 44eee00f4f36c047d5c19f05fb44716903b22221
Author: Ayush Singh <ayush@beagleboard.org>

dt-bindings: beagle: Add BeagleConnect Freedom
    
Add devicetree bindings for the BeagleBoard.org BeagleConnect Freedom,
a wireless-enabled board based on the TI CC1352P7. The board exposes an
MCU that can be attached to a host over USB, UART, SPI or I2C, and is
described as a child node of the corresponding bus.

> diff --git a/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml b/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml
> new file mode 100644
> index 0000000000000..be051a39acdc6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/beagle/beagle,beagleconnect-freedom.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/beagle/beagle,beagleconnect-freedom.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: BeagleBoard.org BeagleConnect Freedom
> +
> +description:
> +  The BeagleBoard.org BeagleConnect Freedom board connected over USB, UART, SPI or I2C.

[ ... ]

> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +unevaluatedProperties: false

[Severity: Medium]
Does unconditionally referencing spi-peripheral-props.yaml while setting
unevaluatedProperties to false restrict the allowed properties strictly to SPI
definitions?

The commit message and description state this node can be attached to USB, UART,
SPI, or I2C buses. If this node is added as a child of a non-SPI bus and
standard bus properties like current-speed or baudrate are specified, the schema
will reject them and fail dt_binding_check.

Should the reference to spi-peripheral-props.yaml be conditionally applied
based on the parent bus type, or should references to peripheral schemas for
the other supported buses also be included?

> +
> +examples:
> +  - |
> +    serial {
> +      mcu {
> +        compatible = "beagle,beagleconnect-freedom";
> +        vbat-supply = <&vbat>;
> +      };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-gb-uart-transport-v3-0-81d0a8a1acf7@beagleboard.org?part=6