Re: [PATCH v3 2/2] Input: aw8697 - Add Awinic AW8697 haptics driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] irq: passing NULL devname to devm_request_threaded_irq()
--

commit dcca01e09d9b46c0ca4b04c76dcbcff656133fd5
Author: Armandas Kvietkus <armandas.kvietkus@proton.me>

Input: aw8697 - Add Awinic AW8697 haptics driver

Add a driver for the Awinic AW8697 LRA haptic driver IC. It supports
FF_RUMBLE and calibrates the LRA resonance at probe. Based on the aw86927
driver.

> diff --git a/drivers/input/misc/aw8697.c b/drivers/input/misc/aw8697.c
> new file mode 100644
> index 0000000000000..9f703f81df213
> --- /dev/null
> +++ b/drivers/input/misc/aw8697.c
[ ... ]
> +static int aw8697_probe(struct i2c_client *client)
> +{
[ ... ]
> +	err = regmap_read(haptics->regmap, AW8697_SYSINT_REG, &val);
> +	if (err)
> +		return dev_err_probe(dev, err, "Failed to clear interrupts\n");
> +
> +	err = devm_request_threaded_irq(dev, client->irq, NULL, aw8697_irq,
> +					IRQF_ONESHOT, NULL, haptics);

[Severity: Low]
Does passing NULL as the devname argument here cause issues with procfs
interrupt reporting? 

The interrupt core assigns this pointer directly to the action name field.
When exposed to userspace via /proc/interrupts, passing NULL causes it to
print (null) when formatted by the seq_file interface, which degrades
diagnostic information. 

Could a valid string like the device name or client name be passed here
instead of NULL?

> +	if (err)
> +		return dev_err_probe(dev, err, "Failed to request irq\n");
> +
> +	INIT_WORK(&haptics->play_work, aw8697_play_work);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013-mainlining-v3-0-fca981f62b57@proton.me?part=2