From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 238FF41167C for ; Tue, 13 Oct 2026 14:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791903536; cv=none; b=GioL6YH2/pPyxU+2EkIKki3xLsoPq5BUQEyWmJtOtaNPFnhpdaxpNzyYqrir1fXp/KY9G5awabnuqwmxpPekgZYGyGjtVMwtYRALLzcB12EedqxLCB63JUKEIqdAvEeu0hG5V9nAG+Cj2FW+N47r8zRrWvfKdOQLjX0RWn5da2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791903536; c=relaxed/simple; bh=OcS5L0vfr/bA0G455WaS8wkUnhNqH6rn0NuScVAMuIg=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=sZI7yfKSmqW2qw+HY+FVRRXmJfBalkLs1kyq/jvsyKL4p0fJ4leVUL8EedT/Vw4QMlQqnW7y9Qn4XXzZG3Vm+5lSV76Z2j86A4ET85gRs+lcPINUA9TfG1DonD9XOTMB17GEAO+XMev/iVPYs8R7ds0pypIMHzqJ2PvlTdvapr4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ACkLY39Z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ACkLY39Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B2721F000FF; Tue, 13 Oct 2026 14:58:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791903534; bh=soFU+qXa0/ORPPu9drT6BB+vJBeOanASsxCKHGvltzc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ACkLY39Zu4orqPJL1n+JAZomNQbxs/iPkqWfeksAkQ0qT8jGcMWVr5ZJXEMAM9qdS 5quIUDGck1qI+vR8W6+CYZStaJLnWICmg2q2YmMCr3YoCTS89xkVHHqzv3MXGQTNaJ qWOWUDky7+zvs1fQu0TsMGPEd8HwxRPgyR3qSEJH6noNLcYRbZoFjpmipiSYqo35E0 3kRL45nw8LAWwVibF1+VzQyAsU9sH8fqYEgsa3/tuadiGoC7B31uFaH0OZRTM77qFb /1ig+FkdP/w6VCYKYHY0WvfZmw/y3Ki34yDDuSQc6IhpeYAHBn8iViN4EVFr0hcTWG lcc/237AKL1VA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/3] drm/nouveau/tegra: Keep the fuse clock enabled while the GPU is powered Reply-To: sashiko-reviews@lists.linux.dev To: "Sasha Levin" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20261013145210.103565-3-sashal@kernel.org> References: <20261013145210.103565-1-sashal@kernel.org> <20261013145210.103565-3-sashal@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 13 Oct 2026 14:58:54 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] nouveau: tegra: clk_fuse leak on power_down failure -- commit 4446c1485fff0b05a5e79c1e4d70e14c4beda300 Author: Sasha Levin drm/nouveau/tegra: Keep the fuse clock enabled while the GPU is powered This commit modifies nouveau's Tegra power management sequence to keep the fuse clock enabled while the GPU is powered. This resolves an issue where the GM20B GPU would fail to initialize on some boots. > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c b/drivers= /gpu/drm/nouveau/nvkm/engine/device/tegra.c > index 3c8d0878891ad..31f8eaa9d6509 100644 > --- a/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/tegra.c [ ... ] > @@ -95,6 +100,8 @@ nvkm_device_tegra_power_down(struct nvkm_device_tegra = *tdev) > return ret; > } > =20 > + clk_disable_unprepare(tdev->clk_fuse); > + > return 0; > } [Severity: Medium] Does this code leak the clk_fuse enable and prepare counts if regulator_disable() fails? If regulator_disable() fails and returns an error, the function immediately returns early. Because the new clk_disable_unprepare() call is positioned at the very end of this function, it is skipped entirely on this error path. Since callers like nvkm_device_tegra_dtor() ignore the return value of nvkm_device_tegra_power_down() and proceed to free the device structure, would this result in a permanent resource leak where the clk_fuse's prepare and enable counts are never decremented? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261013145210.1035= 65-1-sashal@kernel.org?part=3D3