From: sashiko-bot@kernel.org
To: "Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/7] regulator: dt-bindings: ti,lp872x: Deprecate ti,dvs-gpio and ti,update-config
Date: Tue, 13 Oct 2026 18:22:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-170322@kernel.org> (raw)
In-Reply-To: <20261013181417.492252-2-clamor95@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: regulator: ti,lp872x: Deprecated ti,update-config remains in example
--
commit 308202c795df4f41c7d2f8aff005747332d2dc21
Author: Svyatoslav Ryhel <clamor95@gmail.com>
regulator: dt-bindings: ti,lp872x: Deprecate ti,dvs-gpio and ti,update-config
This commit marks ti,dvs-gpio and ti,update-config as deprecated in favor of
using dvs-gpios and the presence of ti,general-config as a trigger to update.
> diff --git a/Documentation/devicetree/bindings/regulator/ti,lp872x.yaml b/Documentation/devicetree/bindings/regulator/ti,lp872x.yaml
> index 8e74dbb3ae303..8216f1e3125d4 100644
> --- a/Documentation/devicetree/bindings/regulator/ti,lp872x.yaml
> +++ b/Documentation/devicetree/bindings/regulator/ti,lp872x.yaml
> @@ -47,10 +47,12 @@ properties:
>
> ti,update-config:
> type: boolean
> + deprecated: true
> description: define it when LP872X_GENERAL_CFG register should be set
[Severity: Low]
Does this deprecated property need to be removed from the example block in this
binding?
Documentation/devicetree/bindings/regulator/ti,lp872x.yaml:examples
examples:
- |
#include <dt-bindings/gpio/gpio.h>
i2c {
...
pmic@7a {
compatible = "ti,lp8725";
reg = <0x7a>;
/* Enable BUCK1,2, no DVS, normal LDO mode, timestep is 256usec */
ti,general-config = /bits/ 8 <0xdd>;
ti,update-config;
Leaving deprecated properties in the example might encourage developers to
copy deprecated code into new device trees.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261013181417.492252-1-clamor95@gmail.com?part=1
next prev parent reply other threads:[~2026-10-13 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 18:14 [PATCH v2 0/7] lp872x: remove platform_data based probing and adjustments Svyatoslav Ryhel
2026-10-13 18:14 ` [PATCH v2 1/7] regulator: dt-bindings: ti,lp872x: Deprecate ti,dvs-gpio and ti,update-config Svyatoslav Ryhel
2026-10-13 18:22 ` sashiko-bot [this message]
2026-10-13 18:14 ` [PATCH v2 2/7] regulator: dt-bindings: ti,lp872x: Document input supplies Svyatoslav Ryhel
2026-10-13 18:14 ` [PATCH v2 3/7] regulator: lp872x: Fold driver header into driver file Svyatoslav Ryhel
2026-10-13 18:14 ` [PATCH v2 4/7] regulator: lp872x: Remove redundant regmap wrappers Svyatoslav Ryhel
2026-10-13 18:14 ` [PATCH v2 5/7] regulator: lp872x: Remove platform_data based probing Svyatoslav Ryhel
2026-10-13 18:27 ` sashiko-bot
2026-10-13 18:14 ` [PATCH v2 6/7] regulator: lp872x: Add support for input and regulator power supplies Svyatoslav Ryhel
2026-10-13 18:14 ` [PATCH v2 7/7] regulator: lp872x: Use macro to fill regulator descriptor Svyatoslav Ryhel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-170322@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox