From: sashiko-bot@kernel.org
To: "Dinh Nguyen" <dinguyen@kernel.org>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: altera: Add support for the Agilex27 SoCDK
Date: Wed, 14 Oct 2026 13:05:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-171314@kernel.org> (raw)
In-Reply-To: <20261014125709.2106261-2-dinguyen@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: Devicetree ABI breakage via removed compatible strings
--
commit b7069576f5ba1a0c7e169fe3bc7f1902d040e447
Author: Dinh Nguyen <dinguyen@kernel.org>
arm64: dts: altera: Add support for the Agilex27 SoCDK
The SoCFPGA Agilex72 platform is being renamed to Agilex27. This commit
removes the agilex72 base DTSI and devkit DTS files, replacing them with
new ones for Agilex27.
[ ... ]
> diff --git a/arch/arm64/boot/dts/altera/socfpga_agilex72_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_agilex27_socdk.dts
> similarity index 67%
> rename from arch/arm64/boot/dts/altera/socfpga_agilex72_socdk.dts
> rename to arch/arm64/boot/dts/altera/socfpga_agilex27_socdk.dts
> index 998f19f492b36..15d331cdeeb47 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_agilex72_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_agilex27_socdk.dts
> @@ -2,11 +2,11 @@
> /*
> * Copyright (C) 2026, Altera Corporation
> */
> -#include "socfpga_agilex72.dtsi"
> +#include "socfpga_agilex27.dtsi"
>
> / {
> - model = "Altera SoCFPGA Agilex72 SoCDK";
> - compatible = "intel,socfpga-agilex72-socdk", "intel,socfpga-agilex72";
> + model = "Altera SoCFPGA Agilex27 SoCDK";
> + compatible = "altr,socfpga-agilex27-socdk", "altr,socfpga-agilex27";
[Severity: Medium]
Does removing the older compatible strings break devicetree ABI compatibility?
If existing bootloaders or user-space software expect to match against
intel,socfpga-agilex72 or intel,socfpga-agilex72-socdk, replacing them
entirely might cause them to fail to boot or bind to this board.
Should the old compatible strings be retained as a fallback in the root node
to ensure backward compatibility?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261014125709.2106261-1-dinguyen@kernel.org?part=2
prev parent reply other threads:[~2026-10-14 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 12:57 [PATCH 1/2] dt-bindings: arm: altera: deprecate intel,socfpga-agilex72 Dinh Nguyen
2026-10-14 12:57 ` [PATCH 2/2] arm64: dts: altera: Add support for the Agilex27 SoCDK Dinh Nguyen
2026-10-14 13:05 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-171314@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox