Re: [PATCH] dt-bindings: cpufreq: qcom-nvmem: Allow generic OPP tables

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: validation failure for array compatibles in OPP tables
--

commit e776719b7efa77cf87d1178c68ac8aa49d25b4a5
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

dt-bindings: cpufreq: qcom-nvmem: Allow generic OPP tables

This commit allows the qcom-nvmem cpufreq binding to reference the generic
OPP schema for generic operating-points-v2 tables. This attempts to fix
validation errors for peripheral OPP tables matching the OPP node-name
pattern.

> diff --git a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
> index 547265b8b118a..fa9330cb3223b 100644
> --- a/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/qcom-cpufreq-nvmem.yaml
> @@ -60,6 +60,13 @@ patternProperties:
>          then:
>            $ref: /schemas/opp/opp-v2-qcom-level.yaml#
>  
> +      - if:
> +          properties:
> +            compatible:
> +              const: operating-points-v2

[Severity: Medium]
Will this strict match fail for fallback compatible arrays used by peripheral
OPP tables?

Peripheral OPP tables, such as GPU OPP tables placed at the root level in
various Qualcomm SoCs, frequently use string arrays for fallback. For example:

    compatible = "operating-points-v2-adreno", "operating-points-v2";

Using const enforces an exact string match, so it will fail against these
arrays. This causes the schema to skip the reference and incorrectly trigger
the unevaluatedProperties: false failure during dt_binding_check and dtbs_check.

Should this use contains with const to properly match these array fallbacks?

> +        then:
> +          $ref: /schemas/opp/opp-v2.yaml#
> +
>      unevaluatedProperties: false
>  
>  allOf:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-opp-v1-1-f18fb6f9bae1@oss.qualcomm.com?part=1