Re: [PATCH v2 1/2] arm64: dts: qcom: Add sm8250-oneplus-common.dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: duplicate KEY_VOLUMEDOWN input event mappings
--

commit 2f072d0e18fa18763e323b09dc9a4287c7ab0878
Author: Frieder Hannenheim <git@fhannenheim.net>

arm64: dts: qcom: Add sm8250-oneplus-common.dtsi

This commit introduces a common device tree include for OnePlus devices
utilizing the Qualcomm sm8250 chipset. It provides shared configurations
including memory mappings, regulators, and hardware button definitions.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-oneplus-common.dtsi
> new file mode 100644
> index 0000000000000..931e381368d94
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8250-oneplus-common.dtsi

[ ... ]

> +	gpio_keys: gpio-keys {
> +		compatible = "gpio-keys";
> +		label = "Volume keys";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vol_up_n &vol_down_n>;
> +
> +		key-vol-up {
> +			label = "Volume Up";
> +			gpios = <&pm8150_gpios 6 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEUP>;
> +			debounce-interval = <15>;
> +			linux,can-disable;
> +			wakeup-source;
> +		};
> +
> +		key-vol-down {
> +			label = "Volume Down";
> +			linux,code = <KEY_VOLUMEDOWN>;
> +			gpios = <&pm8150_gpios 7 GPIO_ACTIVE_LOW>;
> +			debounce-interval = <15>;
> +			linux,can-disable;
> +			wakeup-source;
> +		};
> +	};

[Severity: Medium]
The Volume Down key is explicitly mapped here to PMIC GPIO 7.

[ ... ]

> +&pon_pwrkey {
> +	status = "okay";
> +};
> +
> +&pon_resin {
> +	linux,code = <KEY_VOLUMEDOWN>;
> +
> +	status = "okay";
> +};

[Severity: Medium]
Will mapping KEY_VOLUMEDOWN concurrently to the PMIC resin (reset-in) interrupt
here lead to duplicate input events?

Since both the gpio-keys driver and the PMIC resin driver are instantiated and
bound to KEY_VOLUMEDOWN, won't pressing the hardware button generate two
duplicate input events to the kernel input subsystem? This would cause
userspace volume controls to jump two steps instead of one.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-kebab_dts-v2-0-e783463bffd3@fhannenheim.net?part=1