Re: [PATCH net-next v3 12/13] net: dsa: rzn1-a5psw: Add support for RZ/T2H Ethernet switch

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] net: dsa: mismatch between commit message and frame length adjustment
--

commit c8c80059b5db71015db86eaff104015c66bd88b0
Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

net: dsa: rzn1-a5psw: Add support for RZ/T2H Ethernet switch

This commit adds device tree match data and configuration for the Renesas
RZ/T2H SoC Ethernet switch. It configures the switch for four ports and
specifies the DSA tagging protocol along with management port frame length
settings.

>     Add device tree match data and configuration for the Renesas RZ/T2H
>     SoC Ethernet switch. The RZ/T2H uses the same A5PSW switch IP as RZ/N1
>     but with four ports, the DSA tagging protocol `DSA_TAG_PROTO_RZT2H_ETHSW`,
>     and an additional 8-byte management port frame length adjustment.

> diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
> index 30eca64fb2183..933589084eea3 100644
> --- a/drivers/net/dsa/rzn1_a5psw.c
> +++ b/drivers/net/dsa/rzn1_a5psw.c
> @@ -1334,6 +1334,14 @@ static void a5psw_shutdown(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, NULL);
>  }
>  
> +static const struct a5psw_of_data rzt2h_of_data = {
> +	.nports = 4,
> +	.npcs = 3,
> +	.cpu_port = 3,
> +	.tag_proto = DSA_TAG_PROTO_RZT2H_ETHSW,
> +	.management_port_fixed_frame_len = 0x3fff,

[Severity: Medium]
Is the description in the commit message accurate?

The commit message mentions an "additional 8-byte management port frame length
adjustment", but the code here assigns a fixed maximum frame length of 0x3fff
(16383 bytes) to management_port_fixed_frame_len and contains no 8-byte
adjustment logic.

Could the commit message be updated to match the 0x3fff fixed assignment, or
is the 8-byte adjustment logic missing from the implementation?

> +};
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014131906.990077-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=12