From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19E113F23BE for ; Thu, 15 Oct 2026 19:06:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792091193; cv=none; b=X1JikyXNRlNLkH+5UffBZ4Sq6fI7eNxokv6hSLbiJKmapJtSOBansQ5GeCxjbFTfmhpUzKxi1J/q5R5knVtff2vW1SajQ5zDx5x0Ge1KrjRITbfoqi0iufQmueyOcW2OBkl0MxpINLmFgyRFWZSHycws1NjvmVauIAExxAmESP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792091193; c=relaxed/simple; bh=gDU6Vo7wzauBgKSeLmNOhWycwc4Mjw0doZtylmYXFS0=; h=Message-ID:From:Subject:To:Cc:In-Reply-To:References:Content-Type: Date; b=CLeebM2e8z0vKBGihIAmKN7mvFPfQdnaRLT9ZCG5bXlNrQtH374mCMpsMljpnMDLomXN/5S7n/MeGFwITCjaYwaLECqakA31CcB85G/a91vnQO3FtOjn39AquzLU/tAXxfeOcohPMGlFq8ARqEohdXRnckRG/3SjQgzZgMtBn0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aaTocO0F; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aaTocO0F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72F891F000C4; Thu, 15 Oct 2026 19:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792091191; bh=V4oOWsdkXWlhCRhA4V6tBrbRkRQXYEj4yKUhwmJslNI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=aaTocO0FoGis8eZrX1Og6I3GSNNNsronN/v2aYSgnET9eiVreyMoOvhHcopXKQh7D W7D8Ox9RPZ/gaU0Cb0Yek7k7U7OuBHhOGNfpZxNPpSxjlG5ZSaC2gTASNWKr5Ycxhm uoDfl+HNXYoR6HpqMTS6BzFWVhTrV7nevG1FW7avMBSUUc6NyvtAwGHkYvmCf+pylN vL81oZ1Z2qHTbXxZhFZ0cwPsmd1YhiB2HCF51WAs9TGB2yCiaaDWNMA+O0eaAkvKYa gNi+HbKb6SDrooyR7rzCp+VpaoBF1ttzTYmf7T8TYP0X0C2HTE4EiPzf0ei//FN1ws vRcmvX2gW3Q5Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC 1/2] riscv: dts: spacemit: k1: add PowerVR GPU device node Reply-To: sashiko-reviews@lists.linux.dev To: "Iker Pedrosa" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20261015-orangepi-gpu-v1-1-03566a615660@gmail.com> References: <20261015-orangepi-gpu-v1-0-03566a615660@gmail.com> <20261015-orangepi-gpu-v1-1-03566a615660@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 15 Oct 2026 19:06:31 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Low] dts: build failure due to missing k1-power.h dt-binding header - [Low] dts: undocumented compatible strings for spacemit k1-gpu -- commit 8e44783c41b2ae5db8c6c7e6e7e39b06ba8d49af Author: Iker Pedrosa riscv: dts: spacemit: k1: add PowerVR GPU device node Add device tree node for the Imagination Technologies PowerVR Rogue GPU (BVNC 36.29.52.182 / BXE-2-32) found in the Spacemit K1 SoC. > diff --git a/arch/riscv/boot/dts/spacemit/k1.dtsi b/arch/riscv/boot/dts/s= pacemit/k1.dtsi > index 3fabfd34114b2..82cade2f76fe4 100644 > --- a/arch/riscv/boot/dts/spacemit/k1.dtsi > +++ b/arch/riscv/boot/dts/spacemit/k1.dtsi > @@ -5,6 +5,7 @@ > =20 > #include > #include > +#include [Severity: Low] Does this header exist in the tree? It doesn't appear to be added in this patch or in the tree yet, which causes a fatal preprocessor error and compilation failure. [ ... ] > @@ -1119,6 +1120,17 @@ multimedia-bus { > #size-cells =3D <2>; > dma-ranges =3D <0x0 0x00000000 0x0 0x00000000 0x0 0x80000000>, > <0x0 0x80000000 0x1 0x00000000 0x3 0x80000000>; > + > + gpu: gpu@cac00000 { > + compatible =3D "spacemit,k1-gpu", "img,img-bxe-2-32", "img,img-rogue= "; [Severity: Low] Are these compatible strings documented in a DT binding schema? "spacemit,k1-gpu" and "img,img-bxe-2-32" appear to be undocumented, which w= ill cause dt_binding_check to fail. Omitting them from the schema also means their constraints (like required clocks or power domains) won't be properly validated. > + reg =3D <0x0 0xcac00000 0x0 0x80000>; > + interrupts =3D <75>; > + clocks =3D <&syscon_apmu CLK_GPU>; > + clock-names =3D "core"; > + resets =3D <&syscon_apmu RESET_GPU>; > + power-domains =3D <&syscon_apmu K1_PMDOMAIN_GPU>; [Severity: Low] Is it possible to build this node? This relies on K1_PMDOMAIN_GPU which was presumably provided by the missing spacemit,k1-power.h header mentioned above. > + status =3D "disabled"; > + }; > }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261015-orangepi-g= pu-v1-0-03566a615660@gmail.com?part=3D1