From: sashiko-bot@kernel.org
To: "Aniket Limaye" <a-limaye@ti.com>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: gpio: gpio-davinci: Add the tda54 support
Date: Fri, 16 Oct 2026 04:40:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-173794@kernel.org> (raw)
In-Reply-To: <20261016-upstream-tda54-gpio-v2-1-5c4f8b10cdbc@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: missing interrupt-controller requirements for ti,tda54-gpio
--
commit 4e896075feb00707123d20bb29a2b6cd491b1238
Author: Aniket Limaye <a-limaye@ti.com>
dt-bindings: gpio: gpio-davinci: Add the tda54 support
This commit adds device tree binding support for the new TDA54 GPIO IP,
which supports level-triggered interrupts. It adds the "ti,tda54-gpio"
compatible string to the schema.
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> index 1434d08f8b741..02b6b9a436a68 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> @@ -18,6 +18,7 @@ properties:
> - ti,am654-gpio
> - ti,j721e-gpio
> - ti,am64-gpio
> + - ti,tda54-gpio
[Severity: Medium]
Since the commit message indicates this hardware variant adds support for
level-triggered interrupts, implying the GPIO block acts as an interrupt
provider, should this binding enforce the presence of "interrupt-controller"
and "#interrupt-cells"?
Without an allOf/if-then conditional block requiring these properties
specifically for "ti,tda54-gpio", incomplete device tree nodes missing them
will silently pass schema validation.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-upstream-tda54-gpio-v2-0-5c4f8b10cdbc@ti.com?part=1
next prev parent reply other threads:[~2026-10-16 4:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 4:30 [PATCH v2 0/4] gpio: davinci: Add support for level-triggered interrupts Aniket Limaye
2026-10-16 4:30 ` [PATCH v2 1/4] dt-bindings: gpio: gpio-davinci: Add the tda54 support Aniket Limaye
2026-10-16 4:40 ` sashiko-bot [this message]
2026-10-16 4:30 ` [PATCH v2 2/4] gpio: davinci: Add match data struct for get_irq_chip callback Aniket Limaye
2026-10-16 4:30 ` [PATCH v2 3/4] gpio: davinci: Add support for level-triggered interrupts Aniket Limaye
2026-10-16 4:45 ` sashiko-bot
2026-10-16 4:30 ` [PATCH v2 4/4] gpio: davinci: Add ti,tda54-gpio compatible Aniket Limaye
2026-10-16 4:42 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173794@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=a-limaye@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox