Re: [PATCH net-next v3 1/6] dt-bindings: net: ftgmac100: Add AST2700 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: net: unconditional phy-mode requirement conflicts with use-ncsi
--

commit 400bdacb7816aa92f8043666f3a7c205e84d2f56
Author: Jacky Chou <jacky_chou@aspeedtech.com>

dt-bindings: net: ftgmac100: Add AST2700 compatible

This patch adds AST2700 to the FTGMAC100 compatible list and documents its
RMII RCLK gate requirements. It mandates the phy-mode property for AST2700
and makes the Aspeed MAC compatibles standalone by removing the generic
fallback requirement.

> diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> index d14410018bcf6..0a376b849a916 100644
> --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
[ ... ]
> @@ -82,26 +81,35 @@ allOf:
>            contains:
>              enum:
>                - aspeed,ast2600-mac
> +              - aspeed,ast2700-mac
>      then:
>        properties:
>          resets: true
>      else:
>        properties:
>          resets: false
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: aspeed,ast2700-mac
> +    then:
> +      required:
> +        - phy-mode

[Severity: Medium]
Will this unconditional requirement cause dtbs_check validation failures
for AST2700 device trees configured with NC-SI?

Looking at the driver code in drivers/net/ethernet/faraday/ftgmac100.c:

ftgmac100_probe_dt() {
        ...
        if (of_get_property(np, "use-ncsi", NULL))
                return ftgmac100_probe_ncsi(netdev, priv, pdev);
        ...
}

The driver explicitly bypasses PHY initialization and phy-mode validation
when use-ncsi is present. Because of this, phy-mode is conceptually
unnecessary for such configurations, but this binding schema will force
those device tree nodes to include a meaningless phy-mode property.

Could this binding be updated to only require phy-mode when use-ncsi is
not present?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261015-support_ast2700-v3-0-8d7999171ac4@aspeedtech.com?part=1