From: sashiko-bot@kernel.org
To: "Stefano Radaelli" <stefano.radaelli21@gmail.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev
Cc: robh@kernel.org, conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v1 1/2] arm64: dts: imx8mm-var-dart: Enable WM8904 DMIC input
Date: Fri, 16 Oct 2026 08:49:52 +0000 [thread overview]
Message-ID: <sashiko-outbox-174034@kernel.org> (raw)
In-Reply-To: <5309337578f99886c804c8e4ee82643574f1c19c.1792139809.git.stefano.r@variscite.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ASoC: dt: imx8mm: stale DMIC audio routing to Microphone Jack
--
commit 9bda3c8c55088e18eaa9e764f1a00912ea93534f
Author: Stefano Radaelli <stefano.r@variscite.com>
arm64: dts: imx8mm-var-dart: Enable WM8904 DMIC input
The digital microphone data line is connected to the WM8904 IN1L pin,
but this connection is not described in the device tree. Configure
IN1L as DMICDAT1 to enable the digital microphone capture path.
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi
> index c5f0e22f549b4..183b4f7af009f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi
> @@ -300,6 +300,8 @@ wm8904: audio-codec@1a {
> /bits/ 16 <0x04af 0x324b 0x0010 0x050e>;
> /* GPIO1 = DMIC_CLK, don't touch others */
> wlf,gpio-cfg = <0x0018>, <0xffff>, <0xffff>, <0xffff>;
> + /* DMIC is connected to IN1L */
> + wlf,in1l-as-dmicdat1;
[Severity: Medium]
Does this patch also need to update the simple-audio-card,routing array in
the sound-wm8904 node?
Currently, the routing in arch/arm64/boot/dts/freescale/imx8mm-var-dart.dtsi
still maps IN1L to "Microphone Jack":
sound-wm8904 {
...
simple-audio-card,routing =
...
"IN1L", "Microphone Jack",
"IN1R", "Microphone Jack";
...
}
Exposing an onboard digital microphone (DMIC) as a "Microphone Jack" causes
semantic confusion in ALSA userspace. Audio routing daemons like PulseAudio
and PipeWire use widget names to distinguish between built-in microphones and
external pluggable headsets.
Leaving the newly configured digital IN1L input tied to an external analog
jack breaks userspace jack detection logic and presents incorrect routing
options.
> };
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1792139809.git.stefano.r@variscite.com?part=1
next prev parent reply other threads:[~2026-10-16 8:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 8:40 [PATCH v1 0/2] arm64: dts: imx8mm: Enable DMIC input on Variscite boards Stefano Radaelli
2026-10-16 8:40 ` [PATCH v1 1/2] arm64: dts: imx8mm-var-dart: Enable WM8904 DMIC input Stefano Radaelli
2026-10-16 8:49 ` sashiko-bot [this message]
2026-10-16 8:57 ` Stefano Radaelli
2026-10-16 8:40 ` [PATCH v1 2/2] arm64: dts: imx8mm-var-som: " Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-174034@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=stefano.radaelli21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox