Re: [PATCH v3] arm64: dts: qcom: eliza: Add FastRPC support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: qcom: code and commit message mismatch for ADSP CB7 secondary SID
--

commit 65cfb3003140e4f5597259e88dcf55d5c0434c34
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
Subject: arm64: dts: qcom: eliza: Add FastRPC support

This commit describes the FastRPC nodes for both ADSP and CDSP remoteprocs.
It also sets up the ADSP remote heap memory region required by the Audio PD
and maps the necessary compute contexts and SMMU instances.

> diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
> index a8042291bd075..2ad40cc3ce4f3 100644
> --- a/arch/arm64/boot/dts/qcom/eliza.dtsi
> +++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
[ ... ]
> @@ -2432,6 +2441,69 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
>  				label = "lpass";
>  				qcom,remote-pid = <2>;
>  
> +				fastrpc {
> +					compatible = "qcom,fastrpc";
[ ... ]
> +					compute-cb@7 {
> +						compatible = "qcom,fastrpc-compute-cb";
> +						reg = <7>;
> +
> +						iommus = <&apps_smmu 0x1007 0x40>,
> +							 <&apps_smmu 0x1067 0x0>;

[Severity: Medium]
The changelog notes explicitly state "Use the documented 0x1063-0x1066
secondary ADSP SID values." However, this node configures a secondary SID of
0x1067 for compute-cb@7.

Is this 0x1067 value correct, or should it have been removed to adhere to the
0x1063-0x1066 range mentioned in the patch notes?

> +						dma-coherent;
> +					};
> +				};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-dts-qcom-eliza-add-fastrpc-v3-1-4e3fb632300b@oss.qualcomm.com?part=1