From: sashiko-bot@kernel.org
To: "Igor Belwon" <igor.belwon@mentallysanemainliners.org>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Document Xiaomi 17 Ultra devices
Date: Fri, 16 Oct 2026 20:08:42 +0000 [thread overview]
Message-ID: <sashiko-outbox-174893@kernel.org> (raw)
In-Reply-To: <20261016-nezha-v1-1-a39900dfaadd@mentallysanemainliners.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: arm: qcom: redundant xiaomi,nezha in 2-item kaanapali enum
--
commit 48f6e1cb0f2052f10bc7093b9567a5e4e0437429
Author: Igor Belwon <igor.belwon@mentallysanemainliners.org>
dt-bindings: arm: qcom: Document Xiaomi 17 Ultra devices
This commit adds compatible strings for the Xiaomi 17 Ultra EU and CN
device variants to the Qualcomm arm board bindings.
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 121ca557ce1ef..b0eb7c912b913 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -173,10 +173,19 @@ properties:
> - qcom,hawi-mtp
> - const: qcom,hawi
>
> + - description: Xiaomi 17 Ultra
> + items:
> + - enum:
> + - xiaomi,nezha-cn
> + - xiaomi,nezha-eea
> + - const: xiaomi,nezha
> + - const: qcom,kaanapali
> +
> - items:
> - enum:
> - qcom,kaanapali-mtp
> - qcom,kaanapali-qrd
> + - xiaomi,nezha
> - const: qcom,kaanapali
[Severity: Low]
Should xiaomi,nezha be omitted from this two-item qcom,kaanapali enum in
properties:compatible:oneOf?
The Xiaomi 17 Ultra block right above already defines xiaomi,nezha as the
intermediate base compatible beneath xiaomi,nezha-cn and xiaomi,nezha-eea.
Adding xiaomi,nezha to the two-item enum as well allows a device tree root
node with only compatible = "xiaomi,nezha", "qcom,kaanapali" (missing the
required -cn or -eea regional variant compatible) to pass dtbs_check. Other
multi-variant devices in this file (such as xiaomi,beryllium) only list the
shared base compatible as a const in the three-item entry.
>
> - items:
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-nezha-v1-0-a39900dfaadd@mentallysanemainliners.org?part=1
next prev parent reply other threads:[~2026-10-16 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 20:03 [PATCH 0/2] arm64: dts: qcom: Add support for the Xiaomi 17 Ultra series of devices Igor Belwon
2026-10-16 20:03 ` [PATCH 1/2] dt-bindings: arm: qcom: Document Xiaomi 17 Ultra devices Igor Belwon
2026-10-16 20:08 ` sashiko-bot [this message]
2026-10-16 20:10 ` Igor Belwon
2026-10-16 20:03 ` [PATCH 2/2] arm64: dts: qcom: Add support for Xiaomi 17 Ultra phones Igor Belwon
2026-10-16 20:19 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-174893@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=igor.belwon@mentallysanemainliners.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox