From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH 14/14] ARM: dts: imx6sx-sdb-mqs: remove empty pinctrl-0
Date: Fri, 16 Oct 2026 20:18:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-174907@kernel.org> (raw)
In-Reply-To: <20261016-arm_dts_cleanup2-v1-14-3a0cab9fd784@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] ARM: dts: imx6sx-sdb-mqs: inherited sai1 pinctrl-0 conflicts with audmux
--
commit 7833db678f76ab4ca49bd301d79848b89980d394
Author: Frank Li <Frank.Li@nxp.com>
ARM: dts: imx6sx-sdb-mqs: remove empty pinctrl-0
This commit removes the empty pinctrl-0 property from the sai1 node in
imx6sx-sdb-mqs.dts to resolve a dtbs_check schema validation warning.
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts
> index a4ab2d3e960c4..82ae475a018e1 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sx-sdb-mqs.dts
> @@ -33,7 +33,6 @@ &mqs {
> };
>
> &sai1 {
> - pinctrl-0 = <>;
> status = "okay";
> };
>
[Severity: High]
Does removing pinctrl-0 = <>; here without using /delete-property/ cause
&sai1 to inherit pinctrl-0 = <&pinctrl_sai1>; from imx6sx-sdb.dtsi and
conflict with &audmux at probe time?
imx6sx-sdb-mqs.dts includes imx6sx-sdb.dts, which includes imx6sx-sdb.dtsi
where &sai1 and &audmux are defined as:
arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi:
&audmux {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_audmux>;
status = "okay";
};
...
&sai1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_sai1>;
status = "disabled";
};
In imx6sx-sdb.dtsi, pinctrl_audmux and pinctrl_sai1 configure the same five
CSI pads:
pinctrl_audmux: audmuxgrp {
fsl,pins = <
MX6SX_PAD_CSI_DATA00__AUDMUX_AUD6_TXC 0x130b0
MX6SX_PAD_CSI_DATA01__AUDMUX_AUD6_TXFS 0x130b0
MX6SX_PAD_CSI_HSYNC__AUDMUX_AUD6_TXD 0x120b0
MX6SX_PAD_CSI_VSYNC__AUDMUX_AUD6_RXD 0x130b0
MX6SX_PAD_CSI_PIXCLK__AUDMUX_MCLK 0x130b0
>;
};
...
pinctrl_sai1: sai1grp {
fsl,pins = <
MX6SX_PAD_CSI_DATA00__SAI1_TX_BCLK 0x130b0
MX6SX_PAD_CSI_DATA01__SAI1_TX_SYNC 0x130b0
MX6SX_PAD_CSI_HSYNC__SAI1_TX_DATA_0 0x120b0
MX6SX_PAD_CSI_VSYNC__SAI1_RX_DATA_0 0x130b0
MX6SX_PAD_CSI_PIXCLK__AUDMUX_MCLK 0x130b0
>;
};
In MQS mode, sai1 routes audio internally to the MQS block (&mqs, which uses
pinctrl_mqs on SD2_CLK and SD2_CMD) rather than using external SAI1 pins.
Commit 73691f21e211 ("ARM: dts: imx6sx-sdb: Add MQS support") originally set
pinctrl-0 = <>; in imx6sx-sdb-mqs.dts to override pinctrl-0 = <&pinctrl_sai1>;
from imx6sx-sdb.dtsi while leaving &audmux enabled.
When pinctrl-0 = <>; is simply removed, &sai1 retains pinctrl-0 = <&pinctrl_sai1>;
from imx6sx-sdb.dtsi while both &audmux and &sai1 have status = "okay",
causing pinctrl_bind_pins() -> pin_request() to fail with -EINVAL when the
second device probes.
Should this use /delete-property/ pinctrl-0; (and /delete-property/
pinctrl-names;) instead so that the inherited pinctrl properties are removed
from &sai1?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-arm_dts_cleanup2-v1-0-3a0cab9fd784@nxp.com?part=14
prev parent reply other threads:[~2026-10-16 20:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 20:10 [PATCH 00/14] ARM: dts: imx: cleanup some CHECK_DTBS warnings Frank.Li
2026-10-16 20:10 ` [PATCH 01/14] ARM: dts: imx6q-dms-ba16: remove undocumented property fsl,receive-dpll-mode Frank.Li
2026-10-16 20:10 ` [PATCH 02/14] ARM: dts: imx50-amazon-yoshi: remove undocument property min-frequency Frank.Li
2026-10-16 20:10 ` [PATCH 03/14] ARM: dts: imx6dl-b155v2: add touchscreen size properties Frank.Li
2026-10-16 20:21 ` sashiko-bot
2026-10-16 20:10 ` [PATCH 04/14] ARM: dts: imx6q-gw5400-a: fix SPI NOR flash vendor prefix Frank.Li
2026-10-16 20:10 ` [PATCH 05/14] ARM: dts: imx6dl-prtmvt: remove redundant panel compatible fallback Frank.Li
2026-10-16 20:10 ` [PATCH 06/14] ARM: dts: imx53-smd: change compatible string to dlg,da9053-aa Frank.Li
2026-10-16 20:10 ` [PATCH 07/14] ARM: dts: imx6qdl-savageboard: remove undocument avic,tm097tdh02 Frank.Li
2026-10-16 20:10 ` [PATCH 08/14] ARM: dts: imx6qdl-apalis: remove disabled node "panel-lvds" Frank.Li
2026-10-16 20:10 ` [PATCH 09/14] ARM: dts: imx6ul-tx6ul: remove front compatible string karo,imx6ul-tx6ul-sgtl5000 Frank.Li
2026-10-16 20:10 ` [PATCH 10/14] ARM: dts: imx6qdl-tx6-mb7: remove redundant pixelclk-active for simple panel Frank.Li
2026-10-16 20:10 ` [PATCH 11/14] ARM: dts: imx6q-h100: rename port to port@0 for mipi_csi Frank.Li
2026-10-16 20:10 ` [PATCH 12/14] ARM: dts: imx6qdl-sabrelite: fix typo vync-active Frank.Li
2026-10-16 20:10 ` [PATCH 13/14] ARM: dts: imx6q-novena: use interrupts replace irq-gpio Frank.Li
2026-10-16 20:10 ` [PATCH 14/14] ARM: dts: imx6sx-sdb-mqs: remove empty pinctrl-0 Frank.Li
2026-10-16 20:18 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-174907@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox