Re: [PATCH 2/3] dt-bindings: display: panel: add Smartisan TD4362

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: display: panel: smartisan,td4362 uses PMIC lab/ibb supply names
--

commit 6d3f290b8760784bb6a0903d2ec93dcc896d4221
Author: Lu Chen <tianshi12127@gmail.com>

dt-bindings: display: panel: add Smartisan TD4362

This commit documents the devicetree binding for the Smartisan TD4362
1080x2242 command mode MIPI-DSI panel found in the Smartisan R1
smartphone.

> diff --git a/Documentation/devicetree/bindings/display/panel/smartisan,td4362.yaml b/Documentation/devicetree/bindings/display/panel/smartisan,td4362.yaml
> new file mode 100644
> index 0000000000000..a46bc2f530300
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/smartisan,td4362.yaml
> @@ -0,0 +1,75 @@

[ ... ]

> +properties:
> +  compatible:
> +    items:
> +      - const: smartisan,td4362
> +
> +  reg:
> +    maxItems: 1
> +
> +  vddio-supply:
> +    description: I/O voltage rail
> +
> +  lab-supply:
> +    description: Positive source voltage rail
> +
> +  ibb-supply:
> +    description: Negative source voltage rail

[Severity: Medium]
Should lab-supply and ibb-supply in properties, required, and examples be
named vsp-supply and vsn-supply instead?

In devicetree bindings, *-supply properties on a consumer node describe the
power rail inputs of the panel itself rather than the host PMIC regulator
blocks (Qualcomm LAB and IBB) that supply them.

As noted in the property descriptions (Positive source voltage rail and
Negative source voltage rail) and in other Synaptics TD43xx panel bindings
such as Documentation/devicetree/bindings/display/panel/boe,td4320.yaml,
sony,td4353-jdi.yaml, and synaptics,td4300-panel.yaml, the panel's positive
and negative source voltage inputs are vsp-supply and vsn-supply (wired as
vsp-supply = <&lab>; and vsn-supply = <&ibb>; in the board devicetree).

> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - vddio-supply
> +  - lab-supply
> +  - ibb-supply
> +  - reset-gpios
> +  - port

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261017083531.766557-1-tianshi12127@gmail.com?part=2