Re: [PATCH net-next v2 4/5] dt-bindings: net: maxlinear: add MxL86211C lane mapping support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: net: maxlinear: dead code in else block due to strict select
--

commit 414c3b989bc8453c4971568d53b96638314826bb
Author: Robert Marko <robert.marko@sartura.hr>

dt-bindings: net: maxlinear: add MxL86211C lane mapping support

Describe the optional board-level mapping from physical TPI lanes to the
MxL86211C analog front ends (ASPs). This allows DTS to describe wiring
that differs from the hardware reset mapping.

> diff --git a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> index a0dfb6192d81b..4323be300c721 100644
> --- a/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> +++ b/Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml
> @@ -35,6 +35,7 @@ allOf:
>      else:
>        properties:
>          vddp-supply: false
> +        maxlinear,lane-asp-map: false

[Severity: Medium]
Will this else block ever be reached?

In Documentation/devicetree/bindings/net/maxlinear,gpy2xx.yaml, the schema
contains a restricted select block:

select:
  properties:
    compatible:
      contains:
        const: ethernet-phy-idc133.5400

Since the allOf / if block checks for the exact same condition, it appears
guaranteed to always evaluate to true, as the schema only evaluates nodes
that already passed the select filter.

This seems to make the else block dead code, meaning maxlinear,lane-asp-map: false
is never actually enforced for non-idc133.5400 nodes.

Additionally, does this strict select block prevent the schema from
evaluating older PHYs like GPY215B/C? If the schema restricts evaluation
exclusively to ethernet-phy-idc133.5400, properties like
maxlinear,use-broken-interrupts might skip validation on older PHYs and be
flagged as undocumented during dtbs_check validations.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016112033.949026-1-robert.marko@sartura.hr?part=4