Re: [PATCH v12 3/3] rtc: Add Raspberry Pi 5 RTC driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] rtc: Kconfig RTC_DRV_RPI depends on ARCH_BRCMSTB instead of ARCH_BCM2835
--

commit 764db262bbaebd42035bc0933220419e0e4cbc7d
Author: Sander Speetjens <sander.speetjens@gmail.com>

rtc: Add Raspberry Pi 5 RTC driver

This commit adds the Raspberry Pi 5 RTC driver, which accesses the custom
DA9091 RTC through the Raspberry Pi firmware mailbox, and registers the
raspberrypi-rtc platform device from drivers/firmware/raspberrypi.c on
brcm,bcm2712 machines.

> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 05b9233b94189..6adaf425a76bc 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1999,6 +1999,18 @@ config RTC_DRV_R7301
>  	   This driver can also be built as a module. If so, the module
>  	   will be called rtc-r7301.
>  
> +config RTC_DRV_RPI
> +	tristate "Raspberry Pi RTC"
> +	depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE)
> +	depends on ARCH_BRCMSTB || COMPILE_TEST
> +	default ARCH_BRCMSTB

[Severity: Medium]
Should RTC_DRV_RPI depend on and default to ARCH_BCM2835 instead of
ARCH_BRCMSTB (or rely on the RASPBERRYPI_FIRMWARE dependency)?

In drivers/firmware/Kconfig, RASPBERRYPI_FIRMWARE is gated on ARCH_BCM2835:

config RASPBERRYPI_FIRMWARE
	tristate "Raspberry Pi Firmware Driver"
	depends on ARCH_BCM2835 || COMPILE_TEST
	depends on ARM || ARM64
	depends on MAILBOX
	default ARCH_BCM2835

When COMPILE_TEST=n, a configuration with ARCH_BCM2835=y,
RASPBERRYPI_FIRMWARE=y, and ARCH_BRCMSTB=n will register the
raspberrypi-rtc platform device in rpi_register_rtc_driver(), but
RTC_DRV_RPI cannot be enabled. Conversely, with ARCH_BRCMSTB=y and
ARCH_BCM2835=n, RASPBERRYPI_FIRMWARE cannot be enabled, so RTC_DRV_RPI's
first dependency is not satisfied.

> +	help
> +	  If you say yes here you get support for the RTC found on
> +	  Raspberry Pi 5th gen devices.
> +
> +	  This driver can also be built as a module. If so, the module
> +	  will be called rtc-raspberrypi.
> +
>  config RTC_DRV_STM32
>  	tristate "STM32 RTC"
>  	select REGMAP_MMIO

[ ... ]

> 
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261018143712.1040152-1-sander.speetjens@gmail.com?part=3