Re: [PATCH v5 1/2] media: dt-bindings: imx908: Add Sony IMX908 sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: media: imx908: additionalProperties: false blocks allOf schema
--

commit ff8a8181af73cacaf3f8a03e0acde33eb53bb18b
Author: Lachlan Michael <lachlan.michael@sony.com>

media: dt-bindings: imx908: Add Sony IMX908 sensor

This commit adds device tree bindings and a MAINTAINERS entry for the Sony
IMX908 8.39 megapixel MIPI CSI-2 CMOS image sensor.

> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> new file mode 100644
> index 0000000000000..828db1175e2f5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx908.yaml
> @@ -0,0 +1,108 @@
[ ... ]
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    const: sony,imx908
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - dvdd-supply
> +  - ovdd-supply
> +  - avdd-supply
> +  - port
> +
> +additionalProperties: false

[Severity: Medium]
Should this be unevaluatedProperties: false instead of
additionalProperties: false?

Because the schema references /schemas/media/video-interface-devices.yaml#
in allOf without listing common properties such as rotation, orientation,
lens-focus, or flash-leds under the local properties block, using
additionalProperties: false will cause dtbs_check to reject any
sony,imx908 node that uses those inherited properties.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019014720.2635-1-lachlan.michael@sony.com?part=1