Re: [PATCH v2 1/2] ASoC: dt-bindings: Document FM34NE DSP

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: dsp: relative $ref to sound schemas fails dt_binding_check
--

commit fb615b13d5875feacbe1263da737f849cd8294c6
Author: Svyatoslav Ryhel <clamor95@gmail.com>

ASoC: dt-bindings: Document FM34NE DSP

This commit adds a device tree binding schema for the Fortemedia FM34NE DSP
voice processor used in ASUS Transformer devices.

> diff --git a/Documentation/devicetree/bindings/dsp/asus,tf201-dsp.yaml b/Documentation/devicetree/bindings/dsp/asus,tf201-dsp.yaml
> new file mode 100644
> index 0000000000000..46308a462af16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dsp/asus,tf201-dsp.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/dsp/asus,tf201-dsp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Fortemedia FM34NE based voice processor
> +
> +description:
> +  Fortemedia FM34NE is a hardware voice processor (DSP — Digital Signal
> +  Processor) designed by Fortemedia. It specializes in real-time audio
> +  processing, focusing on noise suppression and echo cancellation.
> +
> +maintainers:
> +  - Svyatoslav Ryhel <clamor95@gmail.com>
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - asus,sl101-dsp
> +      - asus,tf101-dsp
> +      - asus,tf201-dsp
> +      - asus,tf300t-dsp
> +      - asus,tf700t-dsp
> +      - pegatron,chagall-dsp
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: Master clock to the DSP
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  bypass-gpios:
> +    maxItems: 1
> +    description: Signal that switches DSP into programming mode.
> +
> +  vdd-supply: true
> +
> +  port:
> +    $ref: audio-graph-port.yaml#
> +    unevaluatedProperties: false

[Severity: Medium]
Since the $id for this schema is under /schemas/dsp/, relative $ref entries
resolve against http://devicetree.org/schemas/dsp/. Because dai-common.yaml
and audio-graph-port.yaml are located in Documentation/devicetree/bindings/sound/
rather than Documentation/devicetree/bindings/dsp/, won't these relative
references fail to resolve during dt_binding_check?

Should these references use /schemas/sound/dai-common.yaml# and
/schemas/sound/audio-graph-port.yaml# instead?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019101357.117462-1-clamor95@gmail.com?part=1