Re: [PATCH net-next 1/5] dt-bindings: net: add support for Toshiba TC9564

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] dt-bindings: net: snps,dwmac: invalid items list under reset-names
- [Medium] dt-bindings: net: snps,dwmac: missing toshiba,tc9564-xgmac in snps,tso rule
- [Low] MAINTAINERS: wrong filename for toshiba,tc9564-xgmac.yaml binding
--

commit a79ac6443d5804b83846d7672a48631fcd49b078
Author: Alex Elder <elder@riscstar.com>

dt-bindings: net: add support for Toshiba TC9564

This commit adds the devicetree binding for the Toshiba TC9564 XGMAC
Ethernet controller and updates snps,dwmac.yaml to allow up to three
resets.

> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 2218a492817fd..ace827ee4eb6c 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -120,6 +120,7 @@ properties:
>          - starfive,jh7110-dwmac
>          - tesla,fsd-ethqos
>          - thead,th1520-gmac
> +        - toshiba,tc9564-xgmac
>          - ultrarisc,dp1000-gmac

[Severity: Medium]
Should toshiba,tc9564-xgmac also be added to the compatible list under
allOf in snps,dwmac.yaml that guards snps,tso?

In Documentation/devicetree/bindings/net/snps,dwmac.yaml:

allOf:
  - $ref: ethernet-controller.yaml#
  - $ref: snps,dwmac-common.yaml#
  - if:
      properties:
        compatible:
          not:
            contains:
              enum:
                ...
                - snps,dwxgmac
                - snps,dwxgmac-2.10
                - st,spear600-gmac

    then:
      properties:
        snps,tso: false

Because toshiba,tc9564-xgmac.yaml references snps,dwmac.yaml# and
defines compatible solely as const: toshiba,tc9564-xgmac, omitting
toshiba,tc9564-xgmac from that list causes snps,tso: false to be applied
and rejects snps,tso in the new binding and its example during
dt_binding_check.

>  
>    reg:
> @@ -174,17 +175,24 @@ properties:
>  
>    resets:
>      minItems: 1
> -    items:
> -      - description: GMAC stmmaceth reset
> -      - description: AHB or OCP reset
> +    maxItems: 3
>  
>    reset-names:
> -    oneOf:
> -      - items:
> -          - enum: [stmmaceth, ahb]
> -      - items:
> -          - const: stmmaceth
> -          - enum: [ahb, stmmaceth-ocp]
> +    maxItems: 3
> +    items:
> +      - oneOf:
> +          - description: GMAC stmmaceth reset
> +            const: stmmaceth
> +          - description: AHB reset
> +            const: ahb
> +          - description: MAC reset
> +            const: mac-reset
> +          - description: PMA (Physical Medium Attachment) reset
> +            const: pma-reset
> +          - description: XPCS reset
> +            const: xpcs-reset
> +          - description: OCP reset (deprecated)
> +            const: stmmaceth-ocp
>  
>    power-domains:
>      maxItems: 1

[Severity: Medium]
Does writing - oneOf: as a list item under reset-names:items cause
dt_binding_check to fail?

In interrupt-names earlier in snps,dwmac.yaml, items is a mapping:

  interrupt-names:
    minItems: 1
    maxItems: 19
    items:
      oneOf:
        ...

With the leading hyphen in - oneOf: and without minItems: 1, items is
treated as a 1-element list rather than a schema applied to each entry
up to maxItems: 3. This conflicts with maxItems: 3 in the meta-schema
and rejects multi-entry reset-names such as the three resets in
toshiba,tc9564-xgmac.yaml.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 149bc44003bda..55ead3d1007a8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -28305,6 +28305,13 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/misc/pci1179,0220.yaml
>  F:	drivers/misc/tc9564-pci.c
>  
> +TOSHIBA TC9564 DWMAC ETHERNET DRIVER
> +M:	Lorenzo Bianconi <lorenzo.bianconi@oss.qualcomm.com>
> +M:	Alex Elder <elder@kernel.org>
> +M:	Daniel Thompson <danielt@kernel.org>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/net/toshiba,tc9564-dwmac.yaml
> +
>  TOSHIBA WMI HOTKEYS DRIVER
>  M:	Azael Avalos <coproscefalo@gmail.com>
>  L:	platform-driver-x86@vger.kernel.org

[Severity: Low]
Should this file entry reference toshiba,tc9564-xgmac.yaml instead of
toshiba,tc9564-dwmac.yaml to match the file created by this patch?

お伝え

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019030129.1470307-1-elder@riscstar.com?part=1