Re: [PATCH RESEND v10 9/9] arm64: dts: mediatek: Add MediaTek MT6392 PMIC dtsi

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] arm64: dts: mediatek: mt6392 pmic fails pwrap_probe() due to missing ID
--

commit 36e8cdb3fad1df2fc1833ecbab6f1f641807e610
Author: Val Packett <val@packett.cool>

arm64: dts: mediatek: Add MediaTek MT6392 PMIC dtsi

This commit adds the mt6392.dtsi device tree include file for the MediaTek
MT6392 PMIC (providing regulator, keys, pinctrl, and RTC nodes) and includes
it in pumpkin-common.dtsi.

> diff --git a/arch/arm64/boot/dts/mediatek/mt6392.dtsi b/arch/arm64/boot/dts/mediatek/mt6392.dtsi
> new file mode 100644
> index 0000000000000..cc4770d70246c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt6392.dtsi
> @@ -0,0 +1,145 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019 MediaTek Inc.
> + * Copyright (c) 2024 Val Packett <val@packett.cool>
> + * Copyright (c) 2026 Luca Leonardo Scorcia <l.scorcia@gmail.com>
> + */
> +
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/regulator/mediatek,mt6392-regulator.h>
> +
> +&pwrap {
> +	pmic: pmic {
> +		compatible = "mediatek,mt6392";
> +		interrupt-controller;
> +		#interrupt-cells = <2>;

[Severity: High]
Will pwrap_probe() fail with -EINVAL on boards that include mt6392.dtsi?

In drivers/soc/mediatek/mtk-pmic-wrap.c, pwrap_probe() matches the child PMIC
node of pwrap against of_slave_match_tbl:

drivers/soc/mediatek/mtk-pmic-wrap.c:pwrap_probe() {
	...
	if (np->child)
		of_slave_id = of_match_node(of_slave_match_tbl, np->child);

	if (!of_slave_id) {
		dev_dbg(&pdev->dev, "slave pmic should be defined in dts\n");
		return -EINVAL;
	}
	...
}

However, of_slave_match_tbl in drivers/soc/mediatek/mtk-pmic-wrap.c only
lists:

	static const struct of_device_id of_slave_match_tbl[] = {
		{ .compatible = "mediatek,mt6323", .data = &pmic_mt6323 },
		{ .compatible = "mediatek,mt6331", .data = &pmic_mt6331 },
		{ .compatible = "mediatek,mt6351", .data = &pmic_mt6351 },
		{ .compatible = "mediatek,mt6357", .data = &pmic_mt6357 },
		{ .compatible = "mediatek,mt6358", .data = &pmic_mt6358 },
		{ .compatible = "mediatek,mt6359", .data = &pmic_mt6359 },
		{ .compatible = "mediatek,mt6380-regulator", .data = &pmic_mt6380 },
		{ .compatible = "mediatek,mt6397", .data = &pmic_mt6397 },
		{ /* sentinel */ }
	};

Because there is no "mediatek,mt6392" entry in of_slave_match_tbl (and the
pmic node has no fallback compatible string), of_slave_id is NULL and
pwrap_probe() aborts before initializing the regmap or calling
of_platform_populate() for the PMIC and its subdevices.

[ ... ]

> diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> index 805fb82138a80..b19d5792bd896 100644
> --- a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi
> @@ -6,6 +6,8 @@
>  
>  #include <dt-bindings/gpio/gpio.h>
>  
> +#include "mt6392.dtsi"
> +
>  / {

[ ... ]

> @@ -160,6 +162,11 @@ &i2c2 {
>  	status = "okay";
>  };
>  
> +&pmic {
> +	interrupt-parent = <&pio>;
> +	interrupts = <28 IRQ_TYPE_LEVEL_HIGH>;
> +};
> +
>  &uart0 {
>  	status = "okay";
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261020173556.632798-1-l.scorcia@gmail.com?part=9