Re: [PATCH v11 1/3] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: rockchip: undocumented rockchip,rk3568-xpcs compatible in rk3568.dtsi
--

commit b8b1e0bef5d9409b92ce95305440fbc54a7eeb87
Author: Coia Prant <coiaprant@gmail.com>

arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes

This commit adds the Synopsys DesignWare xpcs node and two 125 MHz fixed-clock
nodes for the gmac interfaces to the rk3568 SoC device tree.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index 2f42bf26fd9bf..b1ea84ba86e40 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi

[ ... ]

> @@ -110,6 +124,15 @@ sata0: sata@fc000000 {
>  		status = "disabled";
>  	};
>  
> +	xpcs: ethernet-pcs@fda00000 {
> +		compatible = "rockchip,rk3568-xpcs";
> +		reg = <0x0 0xfda00000 0x0 0x200000>;
> +		clocks = <&cru PCLK_XPCS>, <&cru CLK_XPCS_EEE>;
> +		clock-names = "csr", "eee";
> +		power-domains = <&power RK3568_PD_PIPE>;
> +		status = "disabled";
> +	};

[Severity: Medium]
Does adding the xpcs node (ethernet-pcs@fda00000) with compatible =
"rockchip,rk3568-xpcs" in arch/arm64/boot/dts/rockchip/rk3568.dtsi cause a
dtbs_check regression for rk3568 device trees?

While the commit message notes that dtbs_check skips required property checks
for disabled nodes, scripts/Makefile.dtbs invokes dt-validate with -m by
default:

scripts/Makefile.dtbs:
    DT_CHECKER ?= dt-validate
    DT_CHECKER_FLAGS ?= $(if $(DT_SCHEMA_FILES),-l $(DT_SCHEMA_FILES),-m)

When running dtbs_check on any rk3568 target, dt-validate checks compatible
strings on all nodes regardless of status = "disabled" and fails because
"rockchip,rk3568-xpcs" is not documented under
Documentation/devicetree/bindings/.

In addition, the upstream DesignWare xpcs binding in
Documentation/devicetree/bindings/net/pcs/snps,dw-xpcs.yaml and platform
driver in drivers/net/pcs/pcs-xpcs-plat.c (xpcs_of_ids[]) only match the
snps,dw-xpcs* compatibles:

drivers/net/pcs/pcs-xpcs-plat.c:
    static const struct of_device_id xpcs_of_ids[] = {
        { .compatible = "snps,dw-xpcs", .data = &xpcs_generic },
        { .compatible = "snps,dw-xpcs-gen1-3g", .data = &xpcs_pma_gen1_3g },
        ...
    };

Documentation/devicetree/bindings/net/pcs/snps,dw-xpcs.yaml also restricts
clock-names to "csr", "core", and "pad" (without "eee"), requires reg-names
("direct" or "indirect") for memory-mapped instances, sets
additionalProperties: false, and does not define power-domains or phys, nor
does drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c handle pcs-handle.

Should the "rockchip,rk3568-xpcs" binding schema and driver support be added
before introducing this node and enabling it on boards such as
rk3568-photonicat.dts?

> +
>  	pipe_phy_grf0: syscon@fdc70000 {
>  		compatible = "rockchip,rk3568-pipe-phy-grf", "syscon";
>  		reg = <0x0 0xfdc70000 0x0 0x1000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022025844.150320-1-coiaprant@gmail.com?part=1