Re: [PATCH v5 5/7] riscv: dts: ultrarisc: Add initial device tree for UltraRISC DP1000

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] riscv: dts: ultrarisc: use interrupt-controller node name for plic
--

commit 1a3ff8774c13bffe4745b26609b00045901e6bc4
Author: Jia Wang <wangjia@ultrarisc.com>

riscv: dts: ultrarisc: Add initial device tree for UltraRISC DP1000

This commit adds the base device tree for the UltraRISC DP1000 SoC,
describing its eight CP100 CPU cores, cache topology, and core peripherals.

> diff --git a/arch/riscv/boot/dts/ultrarisc/dp1000.dtsi b/arch/riscv/boot/dts/ultrarisc/dp1000.dtsi
> new file mode 100644
> index 0000000000000..220e000a16989
> --- /dev/null
> +++ b/arch/riscv/boot/dts/ultrarisc/dp1000.dtsi
> @@ -0,0 +1,865 @@

[ ... ]

> +	soc {
> +		compatible = "simple-bus";
> +		ranges;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +
> +		clint: clint@8000000 {
> +			compatible = "ultrarisc,dp1000-clint", "sifive,clint0";
> +			reg = <0x0 0x8000000 0x0 0x100000>;
> +			interrupts-extended = <&cpu0_intc 3>, <&cpu0_intc 7>,
> +					      <&cpu1_intc 3>, <&cpu1_intc 7>,
> +					      <&cpu2_intc 3>, <&cpu2_intc 7>,
> +					      <&cpu3_intc 3>, <&cpu3_intc 7>,
> +					      <&cpu4_intc 3>, <&cpu4_intc 7>,
> +					      <&cpu5_intc 3>, <&cpu5_intc 7>,
> +					      <&cpu6_intc 3>, <&cpu6_intc 7>,
> +					      <&cpu7_intc 3>, <&cpu7_intc 7>;
> +		};
> +
> +		plic: plic@9000000 {
> +			compatible = "ultrarisc,dp1000-plic", "ultrarisc,cp100-plic";
> +			reg = <0x0 0x9000000 0x0 0x4000000>;
> +			#interrupt-cells = <1>;
> +			#address-cells = <0>;
> +			interrupt-controller;

[Severity: Low]
Should the plic node in arch/riscv/boot/dts/ultrarisc/dp1000.dtsi be named
interrupt-controller@9000000 instead of plic@9000000?

Because this node has the interrupt-controller property, dtschema's
interrupt-controller.yaml and
Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
require the node name to match interrupt-controller@<addr>, otherwise running
dtbs_check on boards including dp1000.dtsi will report a nodename validation
warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023-ultrarisc-dts-v5-0-af79dbd6ccec@ultrarisc.com?part=5