Re: [PATCH v2 3/4] dt-bindings: mailbox: goog-mba: Add goog-mba mailbox bindings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: mailbox: google,lga-mailbox-array: wrong $schema and example indent
--

commit 8e0bbd08122b063bf8c9d67ff1997606b186bf0b
Author: Douglas Anderson <dianders@chromium.org>

dt-bindings: mailbox: goog-mba: Add goog-mba mailbox bindings

This commit introduces the devicetree binding schema for the Google MailBox
Array IP block present in Laguna SoCs.

> diff --git a/Documentation/devicetree/bindings/mailbox/google,lga-mailbox-array.yaml b/Documentation/devicetree/bindings/mailbox/google,lga-mailbox-array.yaml
> new file mode 100644
> index 0000000000000..f265993fe71d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/google,lga-mailbox-array.yaml
> @@ -0,0 +1,226 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2025 Google LLC
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mailbox/google,lga-mailbox-array.yaml#
> +$schema: http://devicetree.org/meta-schemas/base.yaml#

[Severity: Low]
Should $schema in
Documentation/devicetree/bindings/mailbox/google,lga-mailbox-array.yaml use
http://devicetree.org/meta-schemas/core.yaml# instead of
http://devicetree.org/meta-schemas/base.yaml#?

In dtschema (see commit 962e62128feb60), meta-schemas/base.yaml# is intended
for common consumer and provider property definitions rather than hardware
device bindings. Using base.yaml# causes dt-doc-validate during make
dt_binding_check to skip the standard device-binding meta-schema checks
included by core.yaml#.

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    soc {
> +      #address-cells = <2>;
> +      #size-cells = <2>;

[Severity: Low]
Could the devicetree block under examples in
Documentation/devicetree/bindings/mailbox/google,lga-mailbox-array.yaml use
4-space indentation instead of 2-space indentation?

Running scripts/dtc/dt-check-style --mode=strict on this file as required by
Documentation/devicetree/bindings/submitting-patches.rst currently fails
because the example nodes and properties are indented by 2 spaces per level
instead of 4 spaces.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023235408.3063350-1-dianders@chromium.org?part=3