Re: [PATCH] dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: display: panel: ilitek,ili7807s: redundant backlight property
--

commit dfbb23459fc3c8847cb20a8c363e813da0ef5bc0
Author: Vishnu Saini <vishnu.saini@oss.qualcomm.com>

dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property

This commit adds the backlight property to the Ilitek ILI7807S DSI panel
devicetree binding schema.

> diff --git a/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml b/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
> index ba8c5bbf8ffc4..46b941c18565d 100644
> --- a/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
> @@ -23,6 +23,8 @@ properties:
>      maxItems: 1
>      description: DSI virtual channel
>  
> +  backlight: true

[Severity: Low]
Is this declaration needed in
Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml?

This binding schema already references panel-common.yaml and uses
unevaluatedProperties: false:

allOf:
  - $ref: panel-common.yaml#
...
unevaluatedProperties: false

Because Documentation/devicetree/bindings/display/panel/panel-common.yaml
already defines the backlight property:

  backlight:
    $ref: /schemas/types.yaml#/definitions/phandle
    description:
      For panels whose backlight is controlled by an external backlight
      controller, this property contains a phandle that references the
      controller.

unevaluatedProperties: false automatically permits all properties defined in
panel-common.yaml without re-listing them under properties (just as
reset-gpios and port are used in this schema without being listed under
properties).

Commit 72cfe73347fac6 ("dt-bindings: display: panel: Drop redundant
properties") previously removed redundant backlight: true entries from panel
bindings that reference panel-common.yaml and use unevaluatedProperties:
false. Unless the intent was to add backlight to the required list, could
this change be dropped?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261025-dlc_backlight-v1-1-1d1c49c3e101@oss.qualcomm.com?part=1