From: sashiko-bot@kernel.org
To: "Olivier Louvignes" <olivier@mgcrea.io>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH RFC 1/2] dt-bindings: mmc: ingenic: Add the X1600
Date: Sun, 25 Oct 2026 14:11:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-184241@kernel.org> (raw)
In-Reply-To: <20261025140325.73204-2-olivier@mgcrea.io>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: mmc: ingenic: dmas and dma-names required for ingenic,x1600-mmc
--
commit 43640170e1ca344d80f3c0f4831c11fa293a023e
Author: Olivier Louvignes <olivier@mgcrea.io>
dt-bindings: mmc: ingenic: Add the X1600
This commit adds the ingenic,x1600-mmc compatible string with
ingenic,x1000-mmc as a fallback to the Ingenic MMC device tree binding
schema.
> diff --git a/Documentation/devicetree/bindings/mmc/ingenic,mmc.yaml b/Documentation/devicetree/bindings/mmc/ingenic,mmc.yaml
> index bb4e0be0c8935..6b26a17982f37 100644
> --- a/Documentation/devicetree/bindings/mmc/ingenic,mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/ingenic,mmc.yaml
> @@ -25,6 +25,9 @@ properties:
> - items:
> - const: ingenic,jz4770-mmc
> - const: ingenic,jz4760-mmc
> + - items:
> + - const: ingenic,x1600-mmc
> + - const: ingenic,x1000-mmc
[Severity: Medium]
The commit message notes that the X1600 MSCs have no request lines to the
system DMA controller and use their own integrated DMA controller instead.
However, in Documentation/devicetree/bindings/mmc/ingenic,mmc.yaml, the
top-level required list still unconditionally includes dmas and dma-names:
required:
- compatible
- reg
- interrupts
- clocks
- clock-names
- dmas
- dma-names
Won't dtbs_check fail when validating X1600 MMC device tree nodes that
omit dmas and dma-names? Should dmas and dma-names be moved to a
conditional block under allOf so that they are disallowed (or not
required) when compatible contains ingenic,x1600-mmc?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261025140325.73204-1-olivier@mgcrea.io?part=1
next prev parent reply other threads:[~2026-10-25 14:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 14:03 [PATCH RFC 0/2] mmc: jz4740: Use the integrated DMA controller on the X1600 Olivier Louvignes
2026-10-25 14:03 ` [PATCH RFC 1/2] dt-bindings: mmc: ingenic: Add " Olivier Louvignes
2026-10-25 14:11 ` sashiko-bot [this message]
2026-10-25 14:03 ` [PATCH RFC 2/2] mmc: jz4740: Use the integrated DMA controller on " Olivier Louvignes
2026-10-25 14:23 ` sashiko-bot
2026-10-26 8:38 ` [PATCH RFC 0/2] " Olivier Louvignes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-184241@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=olivier@mgcrea.io \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox