Re: [RFC net-next 1/3] dt-bindings: net: airoha: npu: add DMA pool memory region

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: net: airoha: memory-region schema rejects dma without ba
--

commit cc6f0348f0ae07c584596be380fd6f15cd65362e
Author: Daniel Pawlik <pawlik.dan@gmail.com>

dt-bindings: net: airoha: npu: add DMA pool memory region

This commit updates the Airoha EN7581 NPU device tree binding to allow an
optional coherent DMA pool memory region after either the firmware region
or the WLAN offload regions.

Link: https://lore.kernel.org/r/atCRsquzA1UxSpCc@mediatek.com

> diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> index aefa19c5b4246..21a1a275003b1 100644
> --- a/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> +++ b/Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
> @@ -42,22 +42,34 @@ properties:
>        - description: wlan irq line5
>  
>    memory-region:
> -    items:
> -      - description: NPU firmware binary region
> -      - description: NPU wlan offload RX buffers region
> -      - description: NPU wlan offload TX buffers region
> -      - description: NPU wlan offload TX packet identifiers region
> -      - description: NPU wlan Block Ack buffers region
> -    minItems: 1
> +    oneOf:
> +      - items:
> +          - description: NPU firmware binary region
> +          - description: Coherent DMA pool for buffers shared with the NPU
> +        minItems: 1
> +      - items:
> +          - description: NPU firmware binary region
> +          - description: NPU wlan offload RX buffers region
> +          - description: NPU wlan offload TX buffers region
> +          - description: NPU wlan offload TX packet identifiers region
> +          - description: NPU wlan Block Ack buffers region
> +          - description: Coherent DMA pool for buffers shared with the NPU
> +        minItems: 4
>  
>    memory-region-names:
> -    items:
> -      - const: firmware
> -      - const: pkt
> -      - const: tx-pkt
> -      - const: tx-bufid
> -      - const: ba
> -    minItems: 1
> +    oneOf:
> +      - items:
> +          - const: firmware
> +          - const: dma
> +        minItems: 1
> +      - items:
> +          - const: firmware
> +          - const: pkt
> +          - const: tx-pkt
> +          - const: tx-bufid
> +          - const: ba
> +          - const: dma
> +        minItems: 4

[Severity: Medium]
Does this schema in Documentation/devicetree/bindings/net/airoha,en7581-npu.yaml
under properties:memory-region and properties:memory-region-names reject valid
device trees that configure WLAN offload with the dma pool when the optional
ba region is omitted?

In drivers/net/ethernet/airoha/airoha_npu.c, airoha_npu_wlan_init_memory()
treats the ba region as optional while requiring tx-bufid, pkt, and tx-pkt:

drivers/net/ethernet/airoha/airoha_npu.c:airoha_npu_wlan_init_memory() {
	...
	if (of_property_match_string(npu->dev->of_node, "memory-region-names",
				     "ba") >= 0) {
		cmd = WLAN_FUNC_SET_WAIT_DRAM_BA_NODE_ADDR;
		err = airoha_npu_wlan_set_reserved_memory(npu, 0, "ba", cmd);
		if (err)
			return err;
	}
	...
}

Because the second oneOf branch validates items positionally with minItems: 4,
a 5-entry list that omits ba and appends dma (firmware, pkt, tx-pkt, tx-bufid,
dma) is checked against the fifth item (const: ba) and fails schema validation.

Should the fifth item in the WLAN oneOf branch allow either ba or dma when
only 5 regions are present?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024154150.45733-1-gilroyscott1970@gmail.com?part=1