From: sashiko-bot@kernel.org
To: "Aleksandrs Vinarskis" <alex@vinarskis.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v7 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345
Date: Mon, 26 Oct 2026 00:02:49 +0000 [thread overview]
Message-ID: <sashiko-outbox-184542@kernel.org> (raw)
In-Reply-To: <20261026-dell-xps-9345-ec-v7-1-828ce301b839@vinarskis.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: syntax error in dell,xps13-9345-ec.yaml example io-channels
--
commit 6b26d06321d0162521ee363bfa4a27b82eb6cc2e
Author: Aleksandrs Vinarskis <alex@vinarskis.com>
dt-bindings: platform: introduce EC for Dell XPS 13 9345
This commit adds Device Tree bindings for the Embedded Controller (EC) in
the Dell XPS 13 9345 (platform codename tributo).
> diff --git a/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> new file mode 100644
> index 0000000000000..29cbb837a31b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml
> @@ -0,0 +1,90 @@
[ ... ]
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + embedded-controller@3b {
> + compatible = "dell,xps13-9345-ec";
> + reg = <0x3b>;
> + interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_LOW>;
> +
> + io-channels = <&pmk8550_vadc 0x14a>,
> + <&pmk8550_vadc 0x14b>,
> + <&pmk8550_vadc 0x144>,
> + <&pmk8550_vadc 0x145>,
> + <&pmk8550_vadc 0x146>,
> + <&pmk8550_vadc 0x147>,
> + <&pmk8550_vadc 0x148>,
> + io-channel-names = "sys_therm1",
[Severity: Low]
In the examples section of
Documentation/devicetree/bindings/embedded-controller/dell,xps13-9345-ec.yaml,
the last entry of io-channels in embedded-controller@3b ends with a comma
instead of a semicolon before io-channel-names.
Should <&pmk8550_vadc 0x148>, end with a semicolon instead so that
dt_binding_check does not fail with a dtc syntax error when compiling the
example?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261026-dell-xps-9345-ec-v7-0-828ce301b839@vinarskis.com?part=1
next prev parent reply other threads:[~2026-10-26 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 23:56 [PATCH v7 0/3] (no cover subject) Aleksandrs Vinarskis
2026-10-25 23:56 ` [PATCH v7 1/3] dt-bindings: platform: introduce EC for Dell XPS 13 9345 Aleksandrs Vinarskis
2026-10-26 0:02 ` sashiko-bot [this message]
2026-10-25 23:56 ` [PATCH v7 2/3] platform: arm64: dell-xps-ec: new driver Aleksandrs Vinarskis
2026-10-26 0:11 ` sashiko-bot
2026-10-25 23:56 ` [PATCH v7 3/3] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC Aleksandrs Vinarskis
2026-10-26 0:12 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-184542@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alex@vinarskis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox