Re: [PATCH 1/3] dt-bindings: power: cw2015: add cw2215, cw2217, and cw2218

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: power: cw2015: shunt-resistor-micro-ohms bounds off by 1000x
--

commit 76be9d50cb26d818a5ec97865e1118988a432963
Author: Chris Morgan <macromorgan@hotmail.com>

dt-bindings: power: cw2015: add cw2215, cw2217, and cw2218

This commit adds device tree binding support for the Cellwise cw2215,
cw2217, and cw2218 battery fuel gauges to cw2015_battery.yaml, including
the shunt-resistor-micro-ohms property and an 80-byte battery profile
constraint.

> diff --git a/Documentation/devicetree/bindings/power/supply/cw2015_battery.yaml b/Documentation/devicetree/bindings/power/supply/cw2015_battery.yaml
> index f7bde324153d8..12d2d9a9cf6fd 100644
> --- a/Documentation/devicetree/bindings/power/supply/cw2015_battery.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/cw2015_battery.yaml

[ ... ]

> @@ -41,7 +40,14 @@ properties:
>  
>    power-supplies:
>      minItems: 1
> -    maxItems: 8 # Should be enough
> +    maxItems: 8  # Should be enough
> +
> +  shunt-resistor-micro-ohms:
> +    description: |
> +      The value, in micro-ohms, of the shunt resistor used for sampling
> +      the battery current.
> +    minimum: 1000000
> +    maximum: 50000000

[Severity: Medium]
Are the minimum and maximum constraints on shunt-resistor-micro-ohms in
Documentation/devicetree/bindings/power/supply/cw2015_battery.yaml off by a
factor of 1000?

Since 1 milliohm equals 1,000 micro-ohms, a typical fuel gauge shunt
resistor range of 1 milliohm to 50 milliohms corresponds to 1000 to 50000
micro-ohms (matching other fuel gauge bindings under
Documentation/devicetree/bindings/power/supply/ such as maxim,max17042.yaml,
richtek,rt9756.yaml, and st,stc3117.yaml).

Setting minimum to 1000000 and maximum to 50000000 specifies 1 ohm to 50
ohms (or nano-ohms), which causes dtbs_check and dt_binding_check to reject
valid micro-ohm values for cellwise,cw2215, cellwise,cw2217, and
cellwise,cw2218 nodes.

Should minimum and maximum be 1000 and 50000 instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261027131751.1724448-1-macroalpha82@gmail.com?part=1