From: sashiko-bot@kernel.org
To: "Qianhui Xu" <xiaqinghuan@mail.ustc.edu.cn>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
media-ci@linuxtv.org
Subject: Re: [PATCH 1/9] dt-bindings: media: add the Qualcomm SM8750 camera subsystem
Date: Wed, 28 Oct 2026 03:52:02 +0000 [thread overview]
Message-ID: <sashiko-outbox-187448@kernel.org> (raw)
In-Reply-To: <20261028034105.326535-2-xiaqinghuan@mail.ustc.edu.cn>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: media: commit message sub-block counts mismatch binding schema
--
commit 73bfcb41d44e2c6c144a357d1065fa300a499b3f
Author: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
dt-bindings: media: add the Qualcomm SM8750 camera subsystem
This commit adds the device tree binding schema for the Qualcomm SM8750
camera subsystem (CAMSS).
> dt-bindings: media: add the Qualcomm SM8750 camera subsystem
>
> SM8750 has six CSIPHY instances, two full and two lite CSIDs, and two
> full plus one lite VFEs behind one camera subsystem. Document the node
> with the register ranges, clocks, interconnects, power domains and the
> sub-block layout of that SoC.
>
> Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml
> new file mode 100644
> index 0000000000000..e0e0722a838c5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml
> @@ -0,0 +1,435 @@
[ ... ]
> + reg:
> + maxItems: 19
> +
> + reg-names:
> + items:
> + - const: csid0
> + - const: csid1
> + - const: csid2
> + - const: csid_lite0
> + - const: csid_lite1
> + - const: csiphy0
> + - const: csiphy1
> + - const: csiphy2
> + - const: csiphy3
> + - const: csiphy4
> + - const: csiphy5
> + - const: csitpg0
> + - const: csitpg1
> + - const: csitpg2
> + - const: vfe0
> + - const: vfe1
> + - const: vfe2
> + - const: vfe_lite0
> + - const: vfe_lite1
[Severity: Medium]
Are the sub-block instance counts in the commit message accurate?
The commit message describes SM8750 as having "two full and two lite
CSIDs, and two full plus one lite VFEs".
However, the binding schema in
Documentation/devicetree/bindings/media/qcom,sm8750-camss.yaml defines
and requires:
- three full CSIDs (csid0, csid1, csid2) and two lite CSIDs (csid_lite0,
csid_lite1) in reg-names and interrupt-names
- three full VFEs (vfe0, vfe1, vfe2) and two lite VFEs (vfe_lite0,
vfe_lite1) across reg-names, clock-names (cpas_vfe0..2, vfe0..2, and
vfe0..2_fast_ahb), interrupt-names, power-domains, and
power-domain-names (ife0..2)
- three CSITPG instances (csitpg0, csitpg1, csitpg2) in reg-names
Should the commit message be updated to match the three full CSIDs and
three full plus two lite VFEs defined in the schema?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261028034105.326535-1-xiaqinghuan@mail.ustc.edu.cn?part=1
next prev parent reply other threads:[~2026-10-28 3:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 3:40 [PATCH 0/9] media: camss: add SM8750 support Qianhui Xu
2026-10-28 3:40 ` [PATCH 1/9] dt-bindings: media: add the Qualcomm SM8750 camera subsystem Qianhui Xu
2026-10-28 3:52 ` sashiko-bot [this message]
2026-10-28 3:40 ` [PATCH 2/9] media: camss: csiphy: add CSIPHY 2.4.0 lane settings for SM8750 Qianhui Xu
2026-10-29 7:53 ` Shuai Liu
2026-10-28 3:40 ` [PATCH 3/9] media: camss: csid: unwind the power-on path through a single error label Qianhui Xu
2026-10-28 3:41 ` [PATCH 4/9] media: camss: csid: add the 980 generation Qianhui Xu
2026-10-28 4:03 ` sashiko-bot
2026-10-29 7:54 ` Shuai Liu
2026-10-28 3:41 ` [PATCH 5/9] media: camss: csid: report frame starts from CSID Qianhui Xu
2026-10-28 4:01 ` sashiko-bot
2026-10-28 3:41 ` [PATCH 6/9] media: camss: video: check that a buffer is DMA contiguous and add a prepare hook Qianhui Xu
2026-10-28 3:41 ` [PATCH 7/9] media: camss: video: stop the subdevices already started when a start fails Qianhui Xu
2026-10-28 3:41 ` [PATCH 8/9] media: camss: vfe: add the gen4 block and SM8750 camera subsystem Qianhui Xu
2026-10-28 4:00 ` sashiko-bot
2026-10-29 7:54 ` Shuai Liu
2026-10-28 3:41 ` [PATCH 9/9] arm64: dts: qcom: sm8750: add the " Qianhui Xu
2026-10-28 4:06 ` sashiko-bot
2026-10-29 7:54 ` Shuai Liu
2026-10-29 9:37 ` [PATCH 0/9] media: camss: add SM8750 support Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-187448@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xiaqinghuan@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox