Re: [PATCH] dt-bindings: interconnect: qcom: Relax child node name pattern

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: interconnect: qcom: unupdated child pattern in allOf blocks
--

commit f673587b21cccff8d6834d16d82048b29f591b52
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: interconnect: qcom: Relax child node name pattern

This commit relaxes the child node patternProperties regex in several
Qualcomm interconnect bindings so that single child nodes can be named
interconnect rather than requiring a suffix.

[ ... ]

> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml b/Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml
> index a0c26de94ccf7..456b56222866d 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml
> @@ -31,9 +31,8 @@ properties:
>      minItems: 1
>      maxItems: 4
>  
> -# Child node's properties
>  patternProperties:
> -  '^interconnect-[a-z0-9]+$':
> +  '^interconnect(-[a-z0-9\-]+)?$':
>      type: object
>      description:
>        The interconnect providers do not have a separate QoS register space,
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml
> index cdae0acf3a1da..0024fd29c0bc3 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml
> @@ -31,9 +31,8 @@ properties:
>      minItems: 1
>      maxItems: 4
>  
> -# Child node's properties
>  patternProperties:
> -  '^interconnect-[a-z0-9]+$':
> +  '^interconnect(-[a-z0-9\-]+)?$':
>      type: object
>      description:
>        The interconnect providers do not have a separate QoS register space,

[Severity: Medium]
In both Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml and
Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml, the top-level
patternProperties entry is relaxed to '^interconnect(-[a-z0-9\-]+)?$', but the
allOf conditional blocks that disallow child interconnect nodes still use the
old pattern:

Documentation/devicetree/bindings/interconnect/qcom,shikra.yaml:
  - if:
      properties:
        compatible:
          const: qcom,shikra-mem-noc-core
    then:
      ...
      patternProperties:
        '^interconnect-[a-z0-9]+$': false
  ...
  - if:
      properties:
        compatible:
          const: qcom,shikra-config-noc
    then:
      ...
      patternProperties:
        '^interconnect-[a-z0-9]+$': false

Documentation/devicetree/bindings/interconnect/qcom,sm6115.yaml:
  - if:
      properties:
        compatible:
          const: qcom,sm6115-bimc
    then:
      ...
      patternProperties:
        '^interconnect-[a-z0-9]+$': false

  - if:
      properties:
        compatible:
          const: qcom,sm6115-cnoc
    then:
      ...
      patternProperties:
        '^interconnect-[a-z0-9]+$': false

Because a child node named interconnect (or with multiple hyphens) matches the
top-level patternProperties but not the pattern in the allOf blocks, won't
prohibited child nodes under qcom,shikra-mem-noc-core, qcom,shikra-config-noc,
qcom,sm6115-bimc, and qcom,sm6115-cnoc silently pass schema validation? Should
those allOf patternProperties entries also be updated to
'^interconnect(-[a-z0-9\-]+)?$': false?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028081243.38562-2-krzysztof.kozlowski@oss.qualcomm.com?part=1