Re: [PATCH 1/4] dt-bindings: interrupt-controller: add Mobileye EyeQ5 PCIe MSI controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: interrupt-controller: invalid gic node in eyeq5-msi example
--

commit 07c2faf713f271c288290325080b191a291097be
Author: Gregory CLEMENT <gregory.clement@bootlin.com>

dt-bindings: interrupt-controller: add Mobileye EyeQ5 PCIe MSI controller

This commit adds the Device Tree binding schema for the Mobileye EyeQ5 PCIe
MSI controller.

> diff --git a/Documentation/devicetree/bindings/interrupt-controller/mobileye,eyeq5-msi.yaml b/Documentation/devicetree/bindings/interrupt-controller/mobileye,eyeq5-msi.yaml
> new file mode 100644
> index 0000000000000..919af55fc8a60
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/mobileye,eyeq5-msi.yaml
> @@ -0,0 +1,120 @@

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/mips-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    / {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +
> +        gic: interrupt-controller {
> +            compatible = "mti,cpu-interrupt-controller";
> +            interrupt-controller;
> +            #interrupt-cells = <3>;
> +        };

[Severity: Low]
Does this gic node in examples cause dt_binding_check to fail against
Documentation/devicetree/bindings/interrupt-controller/mti,cpu-interrupt-controller.yaml?

In mti,cpu-interrupt-controller.yaml, nodes matching mti,cpu-interrupt-controller
are required to have #address-cells set to 0 and #interrupt-cells set to 1:

  properties:
    compatible:
      const: mti,cpu-interrupt-controller

    '#interrupt-cells':
      const: 1

    '#address-cells':
      const: 0

    interrupt-controller: true

  additionalProperties: false

  required:
    - compatible
    - '#interrupt-cells'
    - '#address-cells'
    - interrupt-controller

Since msi0 uses a 3-cell MIPS GIC interrupt specifier
(<GIC_SHARED 7 IRQ_TYPE_LEVEL_HIGH>), should the dummy gic provider node and
root wrapper be dropped from the example, or updated to match mti,gic.yaml?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028-eyeq5_msi-v1-0-c464752fb55f@bootlin.com?part=1