Re: [PATCH v2 6/9] ARM: dts: omap: dm816x: Update USB node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] ARM: dts: omap: dm816x: usb0 and usb1 reg-names order violates DT binding
--

commit 35b005745f908eb885e6f38cec92f9ed09548b10
Author: Andrew Goodbody <andrew.goodbody@linaro.org>

ARM: dts: omap: dm816x: Update USB node

This commit updates the dm816x USB device tree node to use the ti,sysc
interconnect target module wrapper and relative child register offsets so
that USB works with DMA enabled.

> diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> index e3d49651b44ee..b839ee29e9eb5 100644
> --- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> @@ -574,19 +574,28 @@ uart3: serial@48024000 {
>  		};
>  
>  		/* NOTE: USB needs a transceiver driver for phys to work */
> -		usb: usb_otg_hs@47401000 {
> -			compatible = "ti,am33xx-usb";
> -			reg = <0x47401000 0x400000>;
> -			ranges;
> +		usb: target-module@47400000 {
> +			compatible = "ti,sysc-omap4", "ti,sysc";
> +			ti,hwmods = "usb_otg_hs";
> +			reg = <0x47400000 0x4>,
> +			      <0x47400010 0x4>;
> +			reg-names = "rev", "sysc";
> +			ti,sysc-mask = <SYSC_OMAP4_SOFTRESET>;
> +			ti,sysc-midle = <SYSC_IDLE_FORCE>,
> +					<SYSC_IDLE_SMART>;
> +			ti,sysc-sidle = <SYSC_IDLE_SMART>;
> +			ti,sysc-delay-us = <2>;
> +			clocks = <&default_clkctrl DM816_USB_OTG_HS_CLKCTRL 0>;
> +			clock-names = "fck";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> -			ti,hwmods = "usb_otg_hs";
> +			ranges = <0x0 0x47400000 0x8000>;
>  
> -			usb0: usb@47401000 {
> +			usb0: usb@1000 {
>  				compatible = "ti,musb-dm816";
> -				reg = <0x47401400 0x400
> -				       0x47401000 0x200>;
> -				reg-names = "mc", "control";
> +				reg = <0x1000 0x200>,
> +				      <0x1400 0x400>;
> +				reg-names = "control", "mc";
>  				interrupts = <18>;
>  				interrupt-names = "mc";
>  				dr_mode = "host";
> @@ -622,11 +631,11 @@ &cppi41dma 11 1 &cppi41dma 12 1
>  					"tx14", "tx15";
>  			};
>  
> -			usb1: usb@47401800 {
> +			usb1: usb@1800 {
>  				compatible = "ti,musb-dm816";
> -				reg = <0x47401c00 0x400
> -				       0x47401800 0x200>;
> -				reg-names = "mc", "control";
> +				reg = <0x1800 0x200>,
> +				      <0x1c00 0x400>;
> +				reg-names = "control", "mc";

[Severity: Low]
Should usb0 and usb1 keep their reg and reg-names entries ordered as "mc",
"control"?

In Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml, which covers
compatible = "ti,musb-dm816", reg-names is defined with a fixed order:

  reg-names:
    items:
      - const: mc
      - const: control

Swapping the order to "control", "mc" in usb0 (usb@1000) and usb1
(usb@1800) causes dtbs_check schema validation to fail on dm816x device
trees (such as dm8168-evm.dtb), and differs from am33xx.dtsi and
dm814x.dtsi.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261028-patch-ektor5-dm8168-dts-v2-0-4544429251e2@linaro.org?part=6