From: sashiko-bot@kernel.org
To: "Thomas Perrot (Schneider Electric)" <thomas.perrot@bootlin.com>
Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
imx@lists.linux.dev, linux-watchdog@vger.kernel.org,
mfd@lists.linux.dev, robh@kernel.org, conor+dt@kernel.org,
Frank.Li@kernel.org, lee@kernel.org
Subject: Re: [PATCH v9 1/4] dt-bindings: mfd: Add AAEON embedded controller
Date: Thu, 29 Oct 2026 14:57:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-189561@kernel.org> (raw)
In-Reply-To: <20261029-dev-b4-aaeon-mcu-driver-v9-1-f9b6d0cc180d@bootlin.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: mfd: undocumented aaeon vendor prefix for aaeon,srg-imx8p-mcu
--
commit 803bf7ce3719e9dd00495c829416f770a3edc092
Author: Thomas Perrot (Schneider Electric) <thomas.perrot@bootlin.com>
dt-bindings: mfd: Add AAEON embedded controller
This commit adds the device tree binding documentation and MAINTAINERS entry
for the I2C-connected AAEON embedded controller (MCU), which provides GPIO
control and a watchdog timer on AAEON boards.
> diff --git a/Documentation/devicetree/bindings/mfd/aaeon,srg-imx8p-mcu.yaml b/Documentation/devicetree/bindings/mfd/aaeon,srg-imx8p-mcu.yaml
> new file mode 100644
> index 0000000000000..74dccee4310a9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/aaeon,srg-imx8p-mcu.yaml
> @@ -0,0 +1,69 @@
[ ... ]
> +properties:
> + compatible:
> + const: aaeon,srg-imx8p-mcu
[Severity: Low]
Does the "aaeon" vendor prefix need to be documented in
Documentation/devicetree/bindings/vendor-prefixes.yaml as well?
In Documentation/devicetree/bindings/vendor-prefixes.yaml under
patternProperties:
"^9tripod,.*":
description: Shenzhen 9Tripod Innovation and Development CO., LTD.
"^abb,.*":
description: ABB
there is no "^aaeon,.*" entry yet, which causes make dt_binding_check
(via dt-doc-validate) to fail on
Documentation/devicetree/bindings/mfd/aaeon,srg-imx8p-mcu.yaml and
scripts/checkpatch.pl to report an undocumented DT compatible vendor prefix.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029-dev-b4-aaeon-mcu-driver-v9-0-f9b6d0cc180d@bootlin.com?part=1
next prev parent reply other threads:[~2026-10-29 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 14:48 [PATCH v9 0/4] Add support for AAEON SRG-IMX8P MCU Thomas Perrot (Schneider Electric)
2026-10-29 14:48 ` [PATCH v9 1/4] dt-bindings: mfd: Add AAEON embedded controller Thomas Perrot (Schneider Electric)
2026-10-29 14:57 ` sashiko-bot [this message]
2026-10-29 14:48 ` [PATCH v9 2/4] mfd: aaeon: Add SRG-IMX8P MCU driver Thomas Perrot (Schneider Electric)
2026-10-29 14:48 ` [PATCH v9 3/4] gpio: aaeon: Add GPIO driver for SRG-IMX8P MCU Thomas Perrot (Schneider Electric)
2026-10-29 14:48 ` [PATCH v9 4/4] watchdog: aaeon: Add watchdog " Thomas Perrot (Schneider Electric)
2026-10-29 14:57 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-189561@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=lee@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=thomas.perrot@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox