Re: [PATCH 3/5] dts: imx95-phyflex-libra-rdk: Add overlays

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: imx95-phyflex-libra-rdk: missing OF graph link for M.2 BT pwrseq
--

commit 214248ffcd9454f4e28fccad2971f5e7db77d114
Author: Benjamin Hahn <B.Hahn@phytec.de>

dts: imx95-phyflex-libra-rdk: Add overlays

This commit adds devicetree overlays for the SoM temperature sensors and
for M.2 Key-E Wi-Fi/Bluetooth cards using the nxp,88w8987-bt compatible on
imx95-phyflex-libra-rdk.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso b/arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso
> new file mode 100644
> index 0000000000000..1601e04b3940f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk-bluetooth-88w8987.dtso
> @@ -0,0 +1,24 @@
> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
> +/*
> + * Copyright (C) 2026 PHYTEC Messtechnik GmbH
> + */
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +
> +&lpuart8 {
> +	bluetooth {
> +		compatible = "nxp,88w8987-bt";
> +		fw-init-baudrate = <115200>;
> +	};
> +};

[Severity: Medium]
Does lpuart8 also need an OF graph link to the m2-key-e-connector node so
that the M.2 Key-E Bluetooth power sequencer can deassert w-disable2-gpios?

In arch/arm64/boot/dts/freescale/imx95-phyflex-libra-rdk.dts, the base
board defines the M.2 connector without OF graph ports:

	m2-key-e-connector {
		compatible = "pcie-m2-e-connector";
		...
		w-disable1-gpios = <&gpio_expander1 9 GPIO_ACTIVE_LOW>;
		w-disable2-gpios = <&gpio_expander1 10 GPIO_ACTIVE_LOW>;
	};

When CONFIG_POWER_SEQUENCING_PCIE_M2 is enabled, pwrseq_pcie_m2_probe() in
drivers/power/sequencing/pwrseq-pcie-m2.c requests w-disable2-gpios with
GPIOD_OUT_HIGH, asserting the active-low W_nDISABLE2 signal:

	ctx->w_disable2_gpio = devm_gpiod_get_optional(dev, "w-disable2",
						       GPIOD_OUT_HIGH);

When nxp_serdev_probe() in drivers/bluetooth/btnxpuart.c probes the
bluetooth child node under lpuart8, it checks for the M.2 connector via OF
graph endpoints before acquiring and enabling the uart power sequencer
target:

	if (nxp_m2_connector_is_available(&serdev->ctrl->dev)) {
		struct pwrseq_desc *pwrseq;

		pwrseq = pwrseq_get(&serdev->ctrl->dev, "uart");

Without OF graph endpoints connecting lpuart8 and port@3 of
m2-key-e-connector, nxp_m2_connector_is_available() returns false, the uart
pwrseq target is never enabled, and w-disable2-gpios remains asserted.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261030-wip-bhahn-imx95_upstreaming-v1-0-1c1cebb5be99@phytec.de?part=3